Date: Mon, 7 Mar 2016 11:20:44 -0500
From: Aristeu Rozanski <aris@redhat.com>
To: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
Cc: lukasz.anaczkowski@intel.com, mchehab@osg.samsung.com,
        dougthompson@xmission.com, bp@alien8.de, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver
Message-ID: <20160307162044.GT4582@redhat.com>
References: <1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 30

On Mon, Mar 07, 2016 at 03:30:45PM +0100, Hubert Chrzaniuk wrote:
> Patch corrects a typo introduced previously.
> As a result under some configurations dimms were not
> correctly recognized. Problem affects only Xeon Phi architecture.
> 
> Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
> ---
>  drivers/edac/sb_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index e438ee5..f5c6b97 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -1574,7 +1574,7 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
>  				for (cha = 0; cha < KNL_MAX_CHAS; cha++) {
>  					if (knl_get_mc_route(target,
>  						mc_route_reg[cha]) == channel
> -						&& participants[channel]) {
> +						&& !participants[channel]) {
>  						participant_count++;
>  						participants[channel] = 1;
>  						break;

I can confirm this fixes the issues I've seen with the upstream driver.

Acked-by: Aristeu Rozanski <aris@redhat.com>

-- 
Aristeu