Subject: Re: [PATCH 0/3] net: macb: Fix coding style issues
To: Moritz Fischer <moritz.fischer@ettus.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        "David Miller" <davem@davemloft.net>,
        Punnaiah Choudary Kalluri <punnaia@xilinx.com>
References: <1457367460-9123-1-git-send-email-moritz.fischer@ettus.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <56DDB6CA.8000100@atmel.com>
Date: Mon, 7 Mar 2016 18:13:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1457367460-9123-1-git-send-email-moritz.fischer@ettus.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1153
Lines: 38

Le 07/03/2016 17:17, Moritz Fischer a ?crit :
> Hi Nicolas,
> 
> this series deals with most of the checkpatch warnings
> generated for macb. There are two BUG_ON()'s that I didn't touch, yet,
> that were suggested by checkpatch, that I can address in a follow up
> commit if needed.
> Let me know if you want me to split the fixes differently or squash
> them into one commit.

Hi,

I'm not usually fond of this type of patches, but I must admit that this
series corrects some style issues.

So, I would like more feedback from Michal and Cyrille as these changes
may delay some of the not-merged-yet features or more important
work-in-progress on their side.

On the other hand, if we all think it's a calm period for this macb
driver, we may find interesting to merge some "cleanup and style"
enhancements.

Thanks, bye,


> Moritz Fischer (3):
>   net: macb: Fix coding style error message
>   net: macb: Fix more coding style issues
>   net: macb: Address checkpatch 'check' suggestions
> 
>  drivers/net/ethernet/cadence/macb.c | 157 ++++++++++++++++--------------------
>  1 file changed, 71 insertions(+), 86 deletions(-)
> 


-- 
Nicolas Ferre