Message-ID: <1457371538.4085.16.camel@perches.com>
Subject: Re: [PATCH 2/3] net: macb: Fix more coding style issues
From: Joe Perches <joe@perches.com>
To: Moritz Fischer <moritz.fischer@ettus.com>, nicolas.ferre@atmel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 07 Mar 2016 09:25:38 -0800
In-Reply-To: <1457367460-9123-3-git-send-email-moritz.fischer@ettus.com>
References: <1457367460-9123-1-git-send-email-moritz.fischer@ettus.com>
	 <1457367460-9123-3-git-send-email-moritz.fischer@ettus.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 38

On Mon, 2016-03-07 at 08:17 -0800, Moritz Fischer wrote:
> This commit takes care of the coding style warnings
> that are mostly due to a different comment style and
> lines over 80 chars.
[]
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
[]
> @@ -127,8 +126,7 @@ static void hw_writel(struct macb *bp, int offset, u32 value)
> ?	writel_relaxed(value, bp->regs + offset);
> ?}
> ?
> -/*
> - * Find the CPU endianness by using the loopback bit of NCR register. When the
> +/* Find the CPU endianness by using the loopback bit of NCR register. When the
> ? * CPU is in big endian we need to program swaped mode for management

swaped/swapped typo
@@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int first_frag,
> ?static int macb_rx(struct macb *bp, int budget)
> ?{
> ?	int received = 0;
> +	int dropped;

This is an unnecessary and unmentioned change.

> ?	unsigned int tail;
> ?	int first_frag = -1;
> ?
> @@ -968,7 +967,6 @@ static int macb_rx(struct macb *bp, int budget)
> ?		}
> ?
> ?		if (ctrl & MACB_BIT(RX_EOF)) {
> -			int dropped;
> ?			BUG_ON(first_frag == -1);
> ?
> ?			dropped = macb_rx_frame(bp, first_frag, tail);
>