Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbcCGSAW (ORCPT ); Mon, 7 Mar 2016 13:00:22 -0500 Received: from www.linutronix.de ([62.245.132.108]:46257 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbcCGSAR convert rfc822-to-8bit (ORCPT ); Mon, 7 Mar 2016 13:00:17 -0500 Date: Mon, 7 Mar 2016 19:00:09 +0100 From: Sebastian Andrzej Siewior To: Yang Shi Cc: tglx@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point Message-ID: <20160307180009.GF12595@linutronix.de> References: <1456262603-10075-1-git-send-email-yang.shi@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1456262603-10075-1-git-send-email-yang.shi@windriver.com> X-Key-Id: 2A8CF5D1 X-Key-Fingerprint: 6425 4695 FFF0 AA44 66CC 19E6 7B96 E816 2A8C F5D1 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 38 * Yang Shi | 2016-02-23 13:23:23 [-0800]: >I recall the rcuidle version is used by 4.1-rt, but not sure why it is dropped >in 4.4-rt. It looks such fix is still needed. I don't recall while I removed it. It was durring v4.1 -> v4.4 port. In v4.1 we had the idle version only in time_hardirqs_on() + …_off(). You introduced it also to start_critical_timings() + stop_…(). Is this required? In the meantime I bring back the empty macro of trace_preemptirqsoff_hist_rcuidle() back in -RT sine it breaks compile latest v4.4.3-RT9 > kernel/trace/trace_irqsoff.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c >index 36e584f..069942c 100644 >--- a/kernel/trace/trace_irqsoff.c >+++ b/kernel/trace/trace_irqsoff.c >@@ -421,13 +421,13 @@ void start_critical_timings(void) > { > if (preempt_trace() || irq_trace()) > start_critical_timing(CALLER_ADDR0, CALLER_ADDR1); >- trace_preemptirqsoff_hist(TRACE_START, 1); >+ trace_preemptirqsoff_hist_rcuidle(TRACE_START, 1); > } > EXPORT_SYMBOL_GPL(start_critical_timings); > > void stop_critical_timings(void) > { >- trace_preemptirqsoff_hist(TRACE_STOP, 0); >+ trace_preemptirqsoff_hist_rcuidle(TRACE_STOP, 0); > if (preempt_trace() || irq_trace()) > stop_critical_timing(CALLER_ADDR0, CALLER_ADDR1); > } Sebastian