Message-ID: <56DDDAC9.1010600@caviumnetworks.com>
Date: Mon, 7 Mar 2016 11:47:21 -0800
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Robert Richter <robert.richter@caviumnetworks.com>
CC: David Daney <ddaney.cavm@gmail.com>, Will Deacon <will.deacon@arm.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Grant Likely <grant.likely@linaro.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v14 2/6] Documentation, dt, numa: dt bindings for NUMA.
References: <1457049339-23351-1-git-send-email-ddaney.cavm@gmail.com> <1457049339-23351-3-git-send-email-ddaney.cavm@gmail.com> <20160307192220.GA1535@rric.localdomain>
In-Reply-To: <20160307192220.GA1535@rric.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2016 19:47:24.6489 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2131
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3202
Lines: 85

On 03/07/2016 11:22 AM, Robert Richter wrote:
> On 03.03.16 15:55:35, David Daney wrote:
>> From: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>>
>> Add DT bindings for numa mapping of memory, CPUs and IOs.
>>
>> Reviewed-by: Robert Richter <rrichter@cavium.com>
>> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>>   Documentation/devicetree/bindings/numa.txt | 272 +++++++++++++++++++++++++++++
>>   1 file changed, 272 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/numa.txt
>>
>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
>> new file mode 100644
>> index 0000000..ec5ed7c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/numa.txt
>
>> +==============================================================================
>> +3 - distance-map
>> +==============================================================================
>> +
>> +The device tree node distance-map describes the relative
>> +distance (memory latency) between all numa nodes.
>> +
>> +- compatible : Should at least contain "numa-distance-map-v1".
>> +
>> +- distance-matrix
>> +  This property defines a matrix to describe the relative distances
>> +  between all numa nodes.
>> +  It is represented as a list of node pairs and their relative distance.
>> +
>> +  Note:
>> +	1. Each entry represents distance from first node to second node.
>> +	The distances are equal in either direction.
>> +	2. The distance from a node to self (local distance) is represented
>> +	with value 10 and all internode distance should be represented with
>> +	a value greater than 10.
>> +	3. distance-matrix should have entries in lexicographical ascending
>> +	order of nodes.
>> +	4. There must be only one device node distance-map which must reside in the root node.
>
> There is no note that this one is optional, but is it right? The
> default is 10 for local and 20 for remote connections.
>

Do we need to explicitly state that it is optional?  Many node types are 
optional, and their binding specifications don't really talk about their 
being optional.

If the node is present then it has the meaning specified.

If the node is *not* present, then the special meaning described in the 
bindings document does not apply.

In the case of NUMA, this means that all memory is equally distant (i.e. 
it is *Uniform*), and we are not talking about a *Non* *Uniform* Memory 
Architecture (NUMA) system.


> If so, then ...
>
> static int __init of_numa_parse_distance_map(void)
> {
> 	int ret = -EINVAL;
> 	struct device_node *np = of_find_node_by_path("/distance-map");
>
> 	if (!np)
> 		return ret;
>
> must return 0 instead of -EINVAL here.

No, I don't think doing that would be correct.

If there is no "distance-map", then of_numa_init() returns the error 
code.  This causes the code in arch/arm64/kernel/numa.c to fall back to 
the non-NUMA "dummy_numa" case.

By adding your Reviewed-by: Robert Richter <rrichter@cavium.com> tag to 
patch 5/6, where we select between "real" and "dummy_numa", I had 
assumed that you agreed with this approach.

David Daney