Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753494AbcCGUCk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 15:02:40 -0500
Received: from smtp52.i.mail.ru ([94.100.177.112]:51532 "EHLO smtp52.i.mail.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752958AbcCGUCb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 15:02:31 -0500
Subject: Re: sigaltstack breaks swapcontext()
To: Andy Lutomirski <luto@amacapital.net>
References: <568D36A1.1030706@list.ru>
 <CALCETrX+nvBy5JTOsgz-gR9OaT2C7C_Gi-grt_rUJmkXuwX6QQ@mail.gmail.com>
 <568FBE50.7040504@list.ru>
 <CALCETrX5UQXQaQBdyDVS84=Xq1Qd1i6kHYvsJWc_HUSnPhCvyA@mail.gmail.com>
 <569065A6.7040005@list.ru>
 <CALCETrUTuh2HzD8u5LqgrprBKXq68HnXQTvWi2WtOR_1gw8UTg@mail.gmail.com>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
From: Stas Sergeev <stsp@list.ru>
Message-ID: <56DDDE51.8030006@list.ru>
Date: Mon, 7 Mar 2016 23:02:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CALCETrUTuh2HzD8u5LqgrprBKXq68HnXQTvWi2WtOR_1gw8UTg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mras: Ok
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1210
Lines: 29

09.01.2016 04:48, Andy Lutomirski пишет:
> On Fri, Jan 8, 2016 at 5:43 PM, Stas Sergeev <stsp@list.ru> wrote:
>> 09.01.2016 02:24, Andy Lutomirski пишет:
>>> It's not sigaltstack that I'm thinking about.  It's signal delivery.
>>> If you end up in DOS mode with SP coincidentally pointing to the
>>> sigaltstack (but with different SS so it's not really the
>>> sigaltstack), then the signal delivery will malfunction.
>> Will you take care of this one?
>> Looks quite dangerous for dosemu! And absolutely
>> undebuggable: you never know when you hit it.
> I'll try to remember to tack it on to the sigcontext series.
How is this one going?
There seem to be one more bug in sigcontext handling.
dosemu have this code:
---
   /*
    * FIRST thing to do in signal handlers - to avoid being trapped into 
int0x11
    * forever, we must restore the eflags.
    */
   loadflags(eflags_fs_gs.eflags);
---

I quickly checked the kernel code, and it seems the
flags are indeed forgotten, even on ia32! I think the
most dangerous flags are AC and NT. But most of
others are important too. IMHO the safe defaults
should be forced when entering the sighandler.
Would you mind taking a look at this problem too?