Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbcCGUcb (ORCPT ); Mon, 7 Mar 2016 15:32:31 -0500 Received: from mail.kernel.org ([198.145.29.136]:53224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbcCGUcX (ORCPT ); Mon, 7 Mar 2016 15:32:23 -0500 Date: Mon, 7 Mar 2016 14:32:15 -0600 From: Bjorn Helgaas To: Nicolai Stange Cc: Michal Simek , Tomi Valkeinen , Takashi Iwai , Bjorn Helgaas , Lorenzo Pieralisi , Yijing Wang , Yinghai Lu , kbuild test robot , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arch/microblaze: export isa_io_base to modules Message-ID: <20160307203215.GA26149@localhost> References: <1457378964-9865-1-git-send-email-nicstange@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457378964-9865-1-git-send-email-nicstange@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 40 On Mon, Mar 07, 2016 at 08:29:24PM +0100, Nicolai Stange wrote: > As discovered by the kbuild test robot, an allmodconfig build on > microblaze bails out with > > ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined! > ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined! > ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined! > ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined! > ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined! > [... plus dozens more throughout the tree] > > Export isa_io_base to modules by means of EXPORT_SYMBOL(). > > Signed-off-by: Nicolai Stange Acked-by: Bjorn Helgaas Michal, this was sent to you, so I assume you'll handle it. Let me know if you want me to do anything else with it. > --- > arch/microblaze/pci/pci-common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c > index ae838ed..fba7a46 100644 > --- a/arch/microblaze/pci/pci-common.c > +++ b/arch/microblaze/pci/pci-common.c > @@ -48,6 +48,8 @@ static int global_phb_number; /* Global phb counter */ > resource_size_t isa_mem_base; > > unsigned long isa_io_base; > +EXPORT_SYMBOL(isa_io_base); > + > static int pci_bus_count; > > struct pci_controller *pcibios_alloc_controller(struct device_node *dev) > -- > 2.7.2 >