Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753839AbcCGVeN (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Mar 2016 16:34:13 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:54748 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753746AbcCGVeG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Mar 2016 16:34:06 -0500
Date: Mon, 07 Mar 2016 16:34:01 -0500 (EST)
Message-Id: <20160307.163401.1082539079648850099.davem@davemloft.net>
To: khalid.aziz@oracle.com
Cc: corbet@lwn.net, akpm@linux-foundation.org, dingel@linux.vnet.ibm.com,
        bob.picco@oracle.com, kirill.shutemov@linux.intel.com,
        aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com, arnd@arndb.de,
        sparclinux@vger.kernel.org, rob.gardner@oracle.com, mhocko@suse.cz,
        chris.hyser@oracle.com, richard@nod.at, vbabka@suse.cz,
        koct9i@gmail.com, oleg@redhat.com, gthelen@google.com, jack@suse.cz,
        xiexiuqi@huawei.com, Vineet.Gupta1@synopsys.com, luto@kernel.org,
        ebiederm@xmission.com, bsegall@google.com, geert@linux-m68k.org,
        dave@stgolabs.net, adobriyan@gmail.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-arch@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity
 (ADI)
From: David Miller <davem@davemloft.net>
In-Reply-To: <56DDF22D.9090102@oracle.com>
References: <56DDC2B6.6020009@oracle.com>
	<20160307.140915.1323031236840000210.davem@davemloft.net>
	<56DDF22D.9090102@oracle.com>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Mar 2016 13:34:05 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 794
Lines: 19

From: Khalid Aziz <khalid.aziz@oracle.com>
Date: Mon, 7 Mar 2016 14:27:09 -0700

> I agree with your point of view. PSTATE.mcde and TTE.mcd are set in
> response to request from userspace. If userspace asked for them to be
> set, they already know but it was the database guys that asked for
> these two functions and they are the primary customers for the ADI
> feature. I am not crazy about this idea since this extends the
> mprotect API even further but would you consider using the return
> value from mprotect to indicate if PSTATE.mcde or TTE.mcd were already
> set on the given address?

Well, that's the idea.

If the mprotect using MAP_ADI or whatever succeeds, then ADI is
enabled.

Users can thus also pass MAP_ADI as a flag to mmap() to get ADI
protection from the very beginning.