Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753660AbcCGWbe (ORCPT ); Mon, 7 Mar 2016 17:31:34 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:49747 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbcCGWbY (ORCPT ); Mon, 7 Mar 2016 17:31:24 -0500 Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI) To: David Miller References: <56DDC2B6.6020009@oracle.com> <20160307.140915.1323031236840000210.davem@davemloft.net> <56DDF22D.9090102@oracle.com> <20160307.163401.1082539079648850099.davem@davemloft.net> Cc: corbet@lwn.net, akpm@linux-foundation.org, dingel@linux.vnet.ibm.com, bob.picco@oracle.com, kirill.shutemov@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com, arnd@arndb.de, sparclinux@vger.kernel.org, rob.gardner@oracle.com, mhocko@suse.cz, chris.hyser@oracle.com, richard@nod.at, vbabka@suse.cz, koct9i@gmail.com, oleg@redhat.com, gthelen@google.com, jack@suse.cz, xiexiuqi@huawei.com, Vineet.Gupta1@synopsys.com, luto@kernel.org, ebiederm@xmission.com, bsegall@google.com, geert@linux-m68k.org, dave@stgolabs.net, adobriyan@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org From: Khalid Aziz Organization: Oracle Corp Message-ID: <56DE00FF.1080807@oracle.com> Date: Mon, 7 Mar 2016 15:30:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160307.163401.1082539079648850099.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 27 On 03/07/2016 02:34 PM, David Miller wrote: > From: Khalid Aziz > Date: Mon, 7 Mar 2016 14:27:09 -0700 > >> I agree with your point of view. PSTATE.mcde and TTE.mcd are set in >> response to request from userspace. If userspace asked for them to be >> set, they already know but it was the database guys that asked for >> these two functions and they are the primary customers for the ADI >> feature. I am not crazy about this idea since this extends the >> mprotect API even further but would you consider using the return >> value from mprotect to indicate if PSTATE.mcde or TTE.mcd were already >> set on the given address? > > Well, that's the idea. > > If the mprotect using MAP_ADI or whatever succeeds, then ADI is > enabled. > > Users can thus also pass MAP_ADI as a flag to mmap() to get ADI > protection from the very beginning. > MAP_ADI has been sitting in my backlog for some time. Looks like you just raised its priority ;) -- Khalid