Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932814AbcCGXE5 (ORCPT ); Mon, 7 Mar 2016 18:04:57 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:44433 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932541AbcCGXEq (ORCPT ); Mon, 7 Mar 2016 18:04:46 -0500 Date: Tue, 8 Mar 2016 00:04:42 +0100 From: Peter Zijlstra To: Vikas Shivappa Cc: vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 1/6] x86,perf/cqm: Fix cqm handling of grouping events into a cache_group Message-ID: <20160307230442.GU6344@twins.programming.kicks-ass.net> References: <1456876108-28770-1-git-send-email-vikas.shivappa@linux.intel.com> <1456876108-28770-2-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456876108-28770-2-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 439 Lines: 13 On Tue, Mar 01, 2016 at 03:48:23PM -0800, Vikas Shivappa wrote: > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -121,6 +121,7 @@ struct hw_perf_event { > struct { /* intel_cqm */ > int cqm_state; > u32 cqm_rmid; > + bool is_group_event; > struct list_head cqm_events_entry; > struct list_head cqm_groups_entry; > struct list_head cqm_group_entry; Please, no 'bool' in structures.