Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932846AbcCGXNY (ORCPT ); Mon, 7 Mar 2016 18:13:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51181 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932650AbcCGXMY (ORCPT ); Mon, 7 Mar 2016 18:12:24 -0500 Date: Mon, 7 Mar 2016 18:12:20 -0500 From: Jessica Yu To: Andrew Morton Cc: Rasmus Villemoes , Andy Shevchenko , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: sscanf: implement basic character sets Message-ID: <20160307231220.GC12689@packer-debian-8-amd64.digitalocean.com> References: <1456518059-7472-1-git-send-email-jeyu@redhat.com> <20160226202810.GA6566@packer-debian-8-amd64.digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160226202810.GA6566@packer-debian-8-amd64.digitalocean.com> X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 27 +++ Jessica Yu [26/02/16 15:28 -0500]: >+++ Jessica Yu [26/02/16 15:20 -0500]: >>Implement basic character sets for the '%[' conversion specifier. >> >>The '%[' conversion specifier matches a nonempty sequence of characters >>from the specified set of accepted (or with '^', rejected) characters >>between the brackets. The substring matched is to be made up of characters >>in (or not in) the set. This is useful for matching substrings that are >>delimited by something other than spaces. >> >>This implementation differs from its glibc counterpart in the following ways: >>(1) No support for character ranges (e.g., 'a-z' or '0-9') >>(2) The hyphen '-' is not a special character >>(3) The closing bracket ']' cannot be matched >>(4) No support (yet) for discarding matching input ('%*[') >> >>Signed-off-by: Jessica Yu > >Since this version is largely based on Rasmus' sample bitmap code >(with only very minor tweaks), what is the best way to provide >attribution in this case? A Suggested-by: tag or another >Signed-off-by: tag (since actual code is involved)? Andrew, friendly ping on this patch and question? :-) Thanks, Jessica