Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933809AbcCHAVl (ORCPT ); Mon, 7 Mar 2016 19:21:41 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:55055 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933884AbcCHAVf (ORCPT ); Mon, 7 Mar 2016 19:21:35 -0500 From: "Franklin S Cooper Jr." To: Paul Walmsley CC: , , , , , , , , , , , , , Subject: Re: [Patch v4 6/6] ARM: dts: DRA7: Add dt nodes for PWMSS References: <1457383187-17166-1-git-send-email-fcooper@ti.com> <1457383187-17166-7-git-send-email-fcooper@ti.com> Message-ID: <56DE1AE2.5070908@ti.com> Date: Mon, 7 Mar 2016 18:20:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 31 On 03/07/2016 05:53 PM, Paul Walmsley wrote: > On Mon, 7 Mar 2016, Franklin S Cooper Jr wrote: > >> From: Vignesh R >> >> Add PWMSS device tree nodes for DRA7 SoC family and add documentation >> for dt bindings. >> >> Signed-off-by: Vignesh R >> [fcooper@ti.com: Use updated bindings for PWMSS and ePWM] >> Signed-off-by: Franklin S Cooper Jr >> --- >> Version 4 changes: >> Remove hwmod entries. >> Add clocks/clock-names to pwm nodes. > Hmm, what about moving the eqep, ecap DT nodes under the epwmss nodes? > > > - Paul We don't have a driver for eQEP which is why there is no DT entry for it. For eCAP, the original patch series didn't include the eCAP DT nodes and I never verified why this is the case. In our TI tree we have eCAP0 only in the DT. The TRM doesn't state that eCAP0-2 are unsupported so there should be entries for all 3 eCAPs. For AM335x and AM437x, eCAP nodes are already under the ePWMSS nodes.