Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934231AbcCHAWD (ORCPT ); Mon, 7 Mar 2016 19:22:03 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29430 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933874AbcCHAVt (ORCPT ); Mon, 7 Mar 2016 19:21:49 -0500 Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI) To: David Miller References: <56DDC2B6.6020009@oracle.com> <56DDC3EB.8060909@oracle.com> <56DDC776.3040003@oracle.com> <20160307.141600.1873883635480850431.davem@davemloft.net> Cc: rob.gardner@oracle.com, corbet@lwn.net, akpm@linux-foundation.org, dingel@linux.vnet.ibm.com, bob.picco@oracle.com, kirill.shutemov@linux.intel.com, aneesh.kumar@linux.vnet.ibm.com, aarcange@redhat.com, arnd@arndb.de, sparclinux@vger.kernel.org, mhocko@suse.cz, chris.hyser@oracle.com, richard@nod.at, vbabka@suse.cz, koct9i@gmail.com, oleg@redhat.com, gthelen@google.com, jack@suse.cz, xiexiuqi@huawei.com, Vineet.Gupta1@synopsys.com, luto@kernel.org, ebiederm@xmission.com, bsegall@google.com, geert@linux-m68k.org, dave@stgolabs.net, adobriyan@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org From: Khalid Aziz Organization: Oracle Corp Message-ID: <56DE1AF1.40107@oracle.com> Date: Mon, 7 Mar 2016 17:21:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160307.141600.1873883635480850431.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 23 On 03/07/2016 12:16 PM, David Miller wrote: > From: Khalid Aziz > Date: Mon, 7 Mar 2016 11:24:54 -0700 > >> Tags can be cleared by user by setting tag to 0. Tags are >> automatically cleared by the hardware when the mapping for a virtual >> address is removed from TSB (which is why swappable pages are a >> problem), so kernel does not have to do it as part of clean up. > > You might be able to crib some bits for the Tag in the swp_entry_t, it's > 64-bit and you can therefore steal bits from the offset field. > > That way you'll have the ADI tag in the page tables, ready to re-install > at swapin time. > Hi Dave, Can we enable ADI support for swappable pages in a subsequent update after the core functionality is stable on mlock'd pages? Thanks, Khalid