Content-Type: text/plain; charset=UTF-8
From: Ian Munsie <imunsie@au1.ibm.com>
To: Matt Ochs <mrochs@us.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
        Michael Neuling <mikey@neuling.org>, Manoj Kumar <kumarmn@us.ibm.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Michael Ellerman <michaele@au1.ibm.com>
Subject: Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events
In-reply-to: <2E3C996E-C050-426F-878D-F25905E3C584@us.ibm.com>
References: <1457377164-22234-1-git-send-email-imunsie@au.ibm.com> <2E3C996E-C050-426F-878D-F25905E3C584@us.ibm.com>
Date: Tue, 08 Mar 2016 12:42:38 +1100
Message-Id: <1457401187-sup-7130@delenn.ozlabs.ibm.com>
User-Agent: Sup/0.20.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 895
Lines: 27

Excerpts from Matt Ochs's message of 2016-03-08 11:26:55 +1100:
> Any reason for adding these extra lines as part of this commit?

mpe asked for some newlines here in the v1 submission, and it only
really made sense to do so if all the related sections had consistent
whitespace as well.

> > +/*
> > + * AFU driver ops allows an AFU driver to create their own events to pass to
> > + * userspace through the file descriptor as a simpler alternative to overriding
> > + * the read() and poll() calls that works with the generic cxl events. These
> > + * events are given priority over the generic cxl events, so will be delivered
> 
> so _they_ will be delivered

thanks for spotting that...

> > + *
> > + * even_pending() will be called by the cxl driver to check if an event is
> > + * pending (e.g. in select/poll/read calls).
> 
> event_pending() <- missing 't'

...and that.

Cheers,
-Ian