Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbcCHGVc (ORCPT ); Tue, 8 Mar 2016 01:21:32 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:55797 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbcCHGV0 (ORCPT ); Tue, 8 Mar 2016 01:21:26 -0500 From: OGAWA Hirofumi To: "Maciej S. Szmigiero" Cc: Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel Subject: Re: [PATCH] fat: add config option to set UTF-8 mount option by default References: <56DB58FB.9080504@maciej.szmigiero.name> Date: Tue, 08 Mar 2016 15:21:21 +0900 In-Reply-To: <56DB58FB.9080504@maciej.szmigiero.name> (Maciej S. Szmigiero's message of "Sat, 05 Mar 2016 23:08:59 +0100") Message-ID: <87y49t4hi6.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 350 Lines: 18 "Maciej S. Szmigiero" writes: > +#ifdef CONFIG_FAT_DEFAULT_UTF8 > + opts->utf8 = is_vfat; > +#else > + opts->utf8 = 0; > +#endif > + Maybe, better to use IS_ENABLED(CONFIG_FAT_DEFAULT_UTF8)? I.e., opts->utf8 = IS_ENABLED(CONFIG_FAT_DEFAULT_UTF8) && is_vfat; Thanks. -- OGAWA Hirofumi