From: Felipe Balbi <balbi@kernel.org>
To: Felipe Ferreri Tonello <eu@felipetonello.com>,
        Michal Nazarewicz <mina86@mina86.com>, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 4/5] usb: gadget: f_midi: cleanups and typos fixes
In-Reply-To: <56DD4AAF.6060207@felipetonello.com>
References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-5-git-send-email-eu@felipetonello.com> <xa1ttwkm833o.fsf@mina86.com> <17F55117-7DFB-4EE9-811C-7C1BAEA1D09C@felipetonello.com> <xa1toaas7ute.fsf@mina86.com> <2D03FBFE-F890-44C7-AFF1-C2166B2DC903@felipetonello.com> <87bn6qkaff.fsf@intel.com> <56DD4AAF.6060207@felipetonello.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Tue, 08 Mar 2016 09:44:50 +0200
Message-ID: <87egblifbh.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2991
Lines: 84

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Hi,

Felipe Ferreri Tonello <eu@felipetonello.com> writes:
>>> On March 5, 2016 4:28:45 PM GMT+00:00, Michal Nazarewicz <mina86@mina86=
.com> wrote:
>>>>>> On Wed, Mar 02 2016, Felipe F. Tonello wrote:
>>>>>>> @@ -16,7 +16,7 @@
>>>>>>>   *   Copyright (C) 2006 Thumtronics Pty Ltd.
>>>>>>>   *   Ben Williamson <ben.williamson@greyinnovation.com>
>>>>>>>   *
>>>>>>> - * Licensed under the GPL-2 or later.
>>>>>>> + * Licensed under the GPLv2.
>>>>
>>>>> On March 4, 2016 7:17:31 PM GMT+00:00, Michal Nazarewicz
>>>> <mina86@mina86.com> wrote:
>>>>>> Any particular reason to do that?
>>>>
>>>> On Fri, Mar 04 2016, Felipe Ferreri Tonello wrote:
>>>>> Because the kernel is v2 only and not later.=20
>>>>
>>>> Linux as a whole is GPLv2 only, but that doesn=E2=80=99t necessarily m=
ean that
>>>> parts of it cannot be dual licensed (or GPLv2+).  It=E2=80=99s safer t=
o leave
>>>> copyright noticed clear unless you explicitly want your contribution be
>>>> GPLv2 only which brings the whole file GPLv2 only.
>>>>
>>>>> I just tried to make this driver more consistent with the coding
>>>> style
>>>>> used across the kernel. That's it.
>>>>
>>>> Column alignment of field names or RHS of assignment operators is quite
>>>> inconsistent already within drivers/usb/gadget/ which is why I=E2=80=
=99m
>>>> concerned whether this is really helping.
>>>>
>>>> Anyway, I actually don=E2=80=99t care much, just adding my two rappen.
>>>
>>> Right, I am ok with Balbi completely ignoring this patch. But I prefer
>>> to have at least this driver consistent than nothing. Of course I'll
>>> remove the license change I made.
>>=20
>> consistent in what way ?
>
> Source-code.
>
> The goal of this patch is to update this driver coding style to promote
> consistency, readability, and maintainability based on the Linux coding
> style.
>
> If this patch does not achieving that or if that is not necessary, than
> just ignore this patch.

yeah, I don't think that's what you're doing here.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJW3oLyAAoJEIaOsuA1yqRE+FwQAK+pRb5N60t8t7TJ1NeHyiIK
aGOfP7vEFsaS2J9G69zeLlIGsH00nOXcvtdQwWAJPuJiDPR2uCYIUWEcWvc72h+H
n9o0MfHcRxMUkU7CX98VYX0k7ammV3YrAVLTabK4YFw45KgP2RdH54tzgs3AGv3Y
NTAtAlkLfvoNbTpONTbiXbFj4WoBNBRxHAE3oouFYMfe8YpStsz/SXQ8RXO4rGOg
wgqJZwDPLuhtHNYQr/Q3KlvCQoOc8x4yNXbl+sWSfvd7gQtDKew4P9q7ajUneVgU
7Q8DAx5eYMTQBuFVLvjzasq7uj43pTVxCn8M9ARkM80i3ms+mztw606We1dpbpYz
aCkgGstktn3WTC2MmPrs26tZYZF5JdrkG2/+MXNolwSiz6DmiDIkOpsEWnerVZwP
1wYnioqtMjL5lmmC3KCOv8NSAwkHah7H3NmiwAD4S9KVLdz0jtFxb28PQFt8mZck
sufLHkn6efUmWYo0eH+0kj1KsHOuU/CCa50r5yJ94dnBeuBJWgTm0sEyMJITkmX0
PPSMChP7QVUJS/xIKF7uurgly+H50TGT77GuN0MBh1GDKaIRjzcqEp0Jt6rpSB6H
5X9BOC6eN2ZbCZsCNTZ80Fd1CDBFXaX4kctVf85vZdgTPBeKmT+VDmZpC58aQxi9
WXY9vI0QQ2U/AF8umDKn
=PKDc
-----END PGP SIGNATURE-----
--=-=-=--