From: "Chrzaniuk, Hubert" <hubert.chrzaniuk@intel.com>
To: Borislav Petkov <bp@alien8.de>
CC: "Anaczkowski, Lukasz" <lukasz.anaczkowski@intel.com>,
        "mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
        "dougthompson@xmission.com" <dougthompson@xmission.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver
Thread-Topic: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver
Thread-Index: AQHReH30h/h0D+m+AkWSvd7xzRdPB59OGdKAgAEodYA=
Date: Tue, 8 Mar 2016 09:18:33 +0000
Message-ID: <570CC49A75F8F64D9F711A9B9476C48C1FB8AF5B@IRSMSX101.ger.corp.intel.com>
References: <1457361045-26221-1-git-send-email-hubert.chrzaniuk@intel.com>
 <20160307152413.GB27820@pd.tnic>
In-Reply-To: <20160307152413.GB27820@pd.tnic>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 829
Lines: 21

-----Original Message-----
From: Borislav Petkov [mailto:bp@alien8.de] 
Sent: Monday, March 7, 2016 4:24 PM

> Do I see it correctly this one fixes
> d0cdf9003140 ("EDAC, sb_edac: Add Knights Landing (Xeon Phi gen 2) support")
> and needs to go to Linus now otherwise 4.5 is b0rked on KNL?

Yes, that’s right:
1. d0cdf9003140 is the patch I am referring to
2. EDAC for KNL platform on 4.5 will not cause any problems but will not be functional for DIMMs (only for MCDRAM)

> On a related note, that knl_get_dimm_capacity() is huuuge and hard to
> read and could use some nice cleanups and splitting out functionality
> into helper functions...

Thanks, that is a valid point, it will be refactored in a separate patch.
However it would good to fix what we have now, so I still hope to have the patch merged anyway...

-Hubert