Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932324AbcCHJsu (ORCPT ); Tue, 8 Mar 2016 04:48:50 -0500 Received: from mga01.intel.com ([192.55.52.88]:57677 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525AbcCHJsr (ORCPT ); Tue, 8 Mar 2016 04:48:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,556,1449561600"; d="scan'208";a="919206163" From: "Zhang, Rui" To: Michele DiGiorgio , Steven Rostedt CC: "linux-pm@vger.kernel.org" , Ingo Molnar , Javi Merino , "linux-kernel@vger.kernel.org" , Punit Agrawal , Eduardo Valentin Subject: RE: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros Thread-Topic: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros Thread-Index: AQHRc+FbkrjOKhEBeUGziLwnRzi+OJ9EYBYAgAMRSwCAB+XuAA== Date: Tue, 8 Mar 2016 09:48:42 +0000 Message-ID: <744357E9AAD1214791ACBA4B0B9092633A972721@SHSMSX101.ccr.corp.intel.com> References: <1456853934-24715-1-git-send-email-michele.digiorgio@arm.com> <20160301132006.1cda539c@gandalf.local.home> <56D87016.5030903@arm.com> In-Reply-To: <56D87016.5030903@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u289mu16023399 Content-Length: 2644 Lines: 72 Punit and Javi, What do you think of this? I'd like to get your ACK before taking it. Thanks, rui > -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Michele DiGiorgio > Sent: Friday, March 04, 2016 1:11 AM > To: Steven Rostedt > Cc: linux-pm@vger.kernel.org; Ingo Molnar ; Javi > Merino ; linux-kernel@vger.kernel.org; Punit > Agrawal ; Eduardo Valentin > Subject: Re: [PATCH] thermal: trace: migrating thermal traces to use > TRACE_DEFINE_ENUM() macros > > Hello Steven, > > Thanks for acknowledging the patch. > > Will you be merging it or should I refer to somebody else? > > Kind regards, > Michele > > On 01/03/16 18:20, Steven Rostedt wrote: > > On Tue, 1 Mar 2016 17:38:54 +0000 > > Michele Di Giorgio wrote: > > > > > Userspace tools are not aware of how to convert the enums provided > > > by the tracepoints to their corresponding strings. > > > > > > Adding TRACE_DEFINE_ENUM() macros allows to make the enums available > > > to userspace to let the tools know what those enum values represent. > > > > > > In particular, for thermal zone trip types what we obtained before > > > was something like: > > > > > > kworker/1:1-460 [001] 320.372732: thermal_zone_trip: > thermal_zone=soc > > > id=0 trip=1 trip_type=1 > > > > > > Unfortunately, userspace tools do not know how to convert enum > > > values to strings and as a consequence they can only forward the > > > enum value to the output. By using TRACE_DEFINE_ENUM() macros for > > > thermal traces we get the following trace line: > > > > > > kworker/1:1-460 [001] 320.372732: thermal_zone_trip: > thermal_zone=soc > > > id=0 trip=1 trip_type=PASSIVE > > > > > > Userspace tools are now able to better understand the meaning of the > > > trip_type and provide the user with more readable information. > > > > > > > Acked-by: Steven Rostedt > > > > -- Steve > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body > of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html