Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932664AbcCHKJf (ORCPT ); Tue, 8 Mar 2016 05:09:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:47908 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525AbcCHKJ3 (ORCPT ); Tue, 8 Mar 2016 05:09:29 -0500 Subject: Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example To: Geert Uytterhoeven References: <1457375055-5544-1-git-send-email-afaerber@suse.de> Cc: "linux-input@vger.kernel.org" , linux-rockchip , LAKML , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Julien Chauveau , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree , LKML From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <56DEA4D6.10008@suse.de> Date: Tue, 8 Mar 2016 11:09:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1985 Lines: 52 Am 08.03.2016 um 09:54 schrieb Geert Uytterhoeven: > On Mon, Mar 7, 2016 at 7:24 PM, Andreas Färber wrote: >> Drop #address-cells and #size-cells, which are not required by the >> gpio-keys binding documentation, as button sub-nodes are not devices. >> >> Reported-by: Julien Chauveau >> Signed-off-by: Andreas Färber >> --- >> Documentation/devicetree/bindings/input/gpio-keys.txt | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt >> index 21641236c095..1552a11f6786 100644 >> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt >> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt >> @@ -34,8 +34,6 @@ Example nodes: >> >> gpio_keys { While at it, I was told the preferred node naming would be dashes, not underscores. The deeper we dig, the more we find. >> compatible = "gpio-keys"; >> - #address-cells = <1>; >> - #size-cells = <0>; >> autorepeat; Also a white line here may be optically more pleasant. >> button@21 { > > FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd": > (http://www.spinics.net/lists/devicetree/msg117206.html) applied: > > Warning (unit_address_vs_reg): Node /keyboard/button@21 has a unit > name, but no reg property My v2 GeekBox patch did have *-cells and a reg property, but Julien asked I drop that: https://patchwork.kernel.org/patch/8246481/ Are you suggesting we should add a reg property here and drop this patch or go with this patch but follow up to not use @21? > >> label = "GPIO Key UP"; Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)