Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932474AbcCHKQk (ORCPT ); Tue, 8 Mar 2016 05:16:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:48840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbcCHKQd (ORCPT ); Tue, 8 Mar 2016 05:16:33 -0500 Subject: Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example To: Julien Chauveau References: <1457375055-5544-1-git-send-email-afaerber@suse.de> <525564DD-D0D3-4DEB-9306-3A23288FD83F@gmail.com> Cc: Geert Uytterhoeven , "linux-input@vger.kernel.org" , linux-rockchip , LAKML , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree , LKML From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <56DEA67E.8090704@suse.de> Date: Tue, 8 Mar 2016 11:16:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <525564DD-D0D3-4DEB-9306-3A23288FD83F@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1943 Lines: 47 Am 08.03.2016 um 10:41 schrieb Julien Chauveau: > Le 8 mars 2016 à 09:54, Geert Uytterhoeven a écrit : >> On Mon, Mar 7, 2016 at 7:24 PM, Andreas Färber wrote: >>> Drop #address-cells and #size-cells, which are not required by the >>> gpio-keys binding documentation, as button sub-nodes are not devices. >>> >>> Reported-by: Julien Chauveau >>> Signed-off-by: Andreas Färber >>> --- >>> Documentation/devicetree/bindings/input/gpio-keys.txt | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt >>> index 21641236c095..1552a11f6786 100644 >>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt >>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt >>> @@ -34,8 +34,6 @@ Example nodes: >>> >>> gpio_keys { >>> compatible = "gpio-keys"; >>> - #address-cells = <1>; >>> - #size-cells = <0>; >>> autorepeat; >>> button@21 { >> >> FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd": >> (http://www.spinics.net/lists/devicetree/msg117206.html) applied: >> >> Warning (unit_address_vs_reg): Node /keyboard/button@21 has a unit >> name, but no reg property >> > > Hi Andreas, > This means you can also drop the unit-address (the @21 part) for the button. > What about using a more relevant name like "key_up" instead of "button"? Or in my case power-key or power-button. Or would just power suffice? The Landingship baseboard does have four more buttons not yet enabled, so I do need some way to distinguish nodes. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)