Subject: Re: [PATCH 2/5] gpio: gpiolib: Print error number if gpio hog failed
To: Laxman Dewangan <ldewangan@nvidia.com>, <linus.walleij@linaro.org>,
        <robh+dt@kernel.org>
References: <1457438528-29054-1-git-send-email-ldewangan@nvidia.com>
 <1457438528-29054-3-git-send-email-ldewangan@nvidia.com>
CC: <pawel.moll@arm.com>, <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <treding@nvidia.com>, <swarren@wwwdotorg.org>
From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Message-ID: <56DEC54D.6090600@mentor.com>
Date: Tue, 8 Mar 2016 14:27:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Icedove/38.1.0
MIME-Version: 1.0
In-Reply-To: <1457438528-29054-3-git-send-email-ldewangan@nvidia.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1413
Lines: 43

On 08.03.2016 14:02, Laxman Dewangan wrote:
> Print the error number of GPIO hog failed during
> its configurations. This helps in identifying the
> failure without instrumenting the code.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>  drivers/gpio/gpiolib.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bc788b9..7575ebb 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2621,15 +2621,16 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
>  
>  	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
>  	if (IS_ERR(local_desc)) {
> -		pr_err("requesting hog GPIO %s (chip %s, offset %d) failed\n",
> -		       name, chip->label, hwnum);
> +		status = PTR_ERR(local_desc);
> +		pr_err("requesting hog GPIO %s, chip %s, offset %d failed %d\n",
> +		       name, chip->label, hwnum, status);
>  		return PTR_ERR(local_desc);

You can do "return status;" now.

>  	}
>  
>  	status = gpiod_configure_flags(desc, name, dflags);
>  	if (status < 0) {
> -		pr_err("setup of hog GPIO %s (chip %s, offset %d) failed\n",
> -		       name, chip->label, hwnum);
> +		pr_err("setup of hog GPIO %s chip %s, offset %d failed %d\n",
> +		       name, chip->label, hwnum, status);
>  		gpiochip_free_own_desc(desc);
>  		return status;
>  	}
> 

--
With best wishes,
Vladimir