Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbcCHNCd (ORCPT ); Tue, 8 Mar 2016 08:02:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:39885 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbcCHNC0 (ORCPT ); Tue, 8 Mar 2016 08:02:26 -0500 Subject: Re: [PATCH v7 15/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup To: Yaniv Gardi , James.Bottomley@HansenPartnership.com References: <1457440568-13084-1-git-send-email-ygardi@codeaurora.org> <1457440568-13084-16-git-send-email-ygardi@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" From: Hannes Reinecke Message-ID: <56DECD60.9080502@suse.de> Date: Tue, 8 Mar 2016 14:02:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457440568-13084-16-git-send-email-ygardi@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 26 On 03/08/2016 01:36 PM, Yaniv Gardi wrote: > Some UFS devices (and may be host) have issues if LCC is > enabled. So we are setting PA_Local_TX_LCC_Enable to 0 > before link startup which will make sure that both host > and device TX LCC are disabled once link startup is > completed. > > Reviewed-by: Gilad Broner > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 27 ++++++++++++++++++++------- > drivers/scsi/ufs/unipro.h | 1 + > 2 files changed, 21 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg)