Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1457403993.5321.33.camel@linux.vnet.ibm.com>
References: <1457403993.5321.33.camel@linux.vnet.ibm.com> <20160304150022.17121.34501.stgit@warthog.procyon.org.uk> <20160304150149.17121.31855.stgit@warthog.procyon.org.uk>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #2]
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30480.1457442516.1@warthog.procyon.org.uk>
Date: Tue, 08 Mar 2016 13:08:36 +0000
Message-ID: <30481.1457442516@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 23

Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> Only certificates signed by a key on the system keyring were added to
> the IMA keyring, unless IMA_MOK_KEYRING was configured.  Then, the
> certificate could be signed by a either a key on the system or ima_mok
> keyrings.  To replicate this behavior, the default behavior should be to
> only permit certificates signed by a key on the builtin keyring, unless
> this new Kconfig is enabled.  Only then, permit certificates signed by a
> key on either the builtin or secondary keyrings to be added to the IMA
> keyring.

How about I change it to a choice-type item, with the following options:

 (1) No addition.

 (2) Addition restricted by built-in keyring.

 (3) Addition restricted by secondary keyring + built-in keyring.

where the second and third options then depend on the appropriate keyrings
being enabled.

David