Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932115AbcCHOBx (ORCPT ); Tue, 8 Mar 2016 09:01:53 -0500 Received: from mail-yw0-f172.google.com ([209.85.161.172]:35380 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbcCHOBr convert rfc822-to-8bit (ORCPT ); Tue, 8 Mar 2016 09:01:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <1456159001-20307-1-git-send-email-jprvita@endlessm.com> <1456159001-20307-9-git-send-email-jprvita@endlessm.com> <20160226175925.GA9331@w1.fi> <20160229223918.GA32464@w1.fi> <1456839787.3926.20.camel@sipsolutions.net> From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Date: Tue, 8 Mar 2016 09:01:06 -0500 Message-ID: Subject: Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations To: Johannes Berg Cc: Jouni Malinen , "David S. Miller" , Darren Hart , linux-wireless , Network Development , platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, LKML , linux@endlessm.com, =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 26 Hello Johannes, On 1 March 2016 at 11:15, João Paulo Rechi Vita wrote: > On 1 March 2016 at 08:43, Johannes Berg wrote: >> >> I'm fine with Jouni's change, preserving the original behaviour of >> requiring TYPE_ALL or the correct type, but I'm tempted to simply >> remove the type check entirely. >> >> Thoughts? >> > > I think this patch should keep the original logic, as this is supposed > to be a refactor only. If we decide to remove the check, we should to > it in a separate patch, to make it clear for someone looking at the > history later. > > I'm fine with removing the type check (in a separate patch), but I > don't see much gain in doing so. > I just saw you picked this patch with Jouni's fix, thanks! -- João Paulo Rechi Vita http://about.me/jprvita