Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203AbcCHOGH (ORCPT ); Tue, 8 Mar 2016 09:06:07 -0500 Received: from mga01.intel.com ([192.55.52.88]:2117 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbcCHOGD (ORCPT ); Tue, 8 Mar 2016 09:06:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,556,1449561600"; d="asc'?scan'208";a="665827513" From: Felipe Balbi To: Felipe Ferreri Tonello , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michal Nazarewicz , Clemens Ladisch Subject: Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes In-Reply-To: <56DED984.3090702@felipetonello.com> References: <1456947640-20673-1-git-send-email-eu@felipetonello.com> <1456947640-20673-4-git-send-email-eu@felipetonello.com> <87wppi67c5.fsf@ti.com> <270D9ECD-1810-48BC-BBE9-9C9DD5E44D4F@felipetonello.com> <87egbmkah0.fsf@intel.com> <56DD4C84.1090506@felipetonello.com> <87ziuaimf8.fsf@intel.com> <56DD6241.2000308@felipetonello.com> <87h9ghife2.fsf@intel.com> <56DED984.3090702@felipetonello.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Tue, 08 Mar 2016 16:04:56 +0200 Message-ID: <87oaapgj5j.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2302 Lines: 69 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Felipe Ferreri Tonello writes: >>> its easy and simple to setup and use. So I think before we have some >>=20 >> so is configfs. >>=20 >>> sort of preset library of configfs-based gadget drivers, we still need >>> these modules. >>=20 >> there is already a library called libusbg. > > By preset library I meant scripts or little programs that implement the > legacy drivers we have. like this ? https://github.com/libusbgx/libusbgx/blob/master/examples/gadget-midi.c >>> Any suggestions on that? >>> >>> Do you want to support what I am proposing for gmidi.ko or just ignore >>> it and move on to configfs? >>=20 >> I prefer to not touch these gadget drivers if at all necessary. If you >> fixing a bug, then sure we must fix bugs. But you're not fixing a bug >> and, on top of that, you're adding regressions and violating the USB >> spec. This shows that you're writing these patches without knowing >> (and/or even caring about) the specification at all. > > Yes, I see your point. My mistake was to not to enforce the first bit to > be set enabling the user to break the USB spec. I didn't think of that right, that was the problem. > scenario. And that's why it's always useful to have kernel maintainers > and others to provide such insights. :) yeah, no problem ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW3twIAAoJEIaOsuA1yqRE93IQAJyOKTUVfMz3L0Q8/zUYgrdq bqq3OvwJryGB5+EjHXw6nRMV8CzPn/q3rg8umwVECz+5+0o5ZZh6pFXe8lSE9W8n 7h276GFezg7ybFD2IMFH2mXyAA4yY5zYLHZwG3kH9x12IbyozEBeBgMGrqNYwowf oVtZm85Npe01Fk9MkUS3qRMPA1S6IZrIfZ1nK7v/yggAthd/Vsgt7BJEuqLE/0PM L/9ZSYzUgpShOisNBryLAfPTwEPCFE+fefwoDhkmq5RUeqBeZK02c0GgEmiNm5va IO1tEqHNLFtVoqnzVDqyRUp1oOUnSzunFEwxmR8DoIxaGnYOX24HRaSvcYd4HKpW P6x2BeD0NKq3Kh6KUPxLQAXzYTYqKduFuIEzIS/AH+SIR+PB2UijMzijM2NL3vfS pMw81/1jv0EQMeL2qKrcxqyZBfIJra90CaCIvzAe/pIYHa77AS6wa3rwtBzZeQFo 0uILdXn82xV9kHJ2MCb1FvJUGpUcYSzB0AY1X0sl0v4rT943KH1I9Hj+n8kfeYfW aVlkkttPhZZdEow4wWLzfgQDWH1mvljtZCFbN4UTvC+S6ra9Hpc2SyL54L+vKmxO MPJSRGOiVKi8LqRKyAcJ0EakNq+Ypmmd9oNou4spPNmzHsuRQeQZmBvwFnHFzr94 6O3T8Mibvc3dVtMqu6y6 =y3pW -----END PGP SIGNATURE----- --=-=-=--