Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbcCHOd3 (ORCPT ); Tue, 8 Mar 2016 09:33:29 -0500 Received: from smtprelay0234.hostedemail.com ([216.40.44.234]:41414 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751836AbcCHOdU (ORCPT ); Tue, 8 Mar 2016 09:33:20 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1561:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3876:3877:5007:6114:6261:6642:7875:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12517:12519:12663:12740:13069:13311:13357:13439:14659:14721:21080:21212:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: uncle91_572c67d222d1c X-Filterd-Recvd-Size: 1179 Date: Tue, 8 Mar 2016 09:33:17 -0500 From: Steven Rostedt To: Chunyu Hu Cc: liwan@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tracing: make tracer_flags use the right set_flag callback Message-ID: <20160308093317.241d55a9@gandalf.local.home> In-Reply-To: <1457444222-8654-1-git-send-email-chuhu@redhat.com> References: <1457444222-8654-1-git-send-email-chuhu@redhat.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 333 Lines: 16 On Tue, 8 Mar 2016 21:37:01 +0800 Chunyu Hu wrote: > @@ -6373,7 +6384,6 @@ create_trace_option_files(struct trace_array *tr, struct tracer *tracer) > struct tracer_flags *flags; > struct tracer_opt *opts; > int cnt; > - int i; I'm guessing this was a mistake. -- Steve > > if (!tracer) > return;