Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932254AbcCHOwh (ORCPT ); Tue, 8 Mar 2016 09:52:37 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:52736 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbcCHOwg (ORCPT ); Tue, 8 Mar 2016 09:52:36 -0500 Date: Tue, 8 Mar 2016 15:52:30 +0100 From: Andrew Lunn To: Neil Armstrong Cc: davem@davemloft.net, f.fainelli@gmail.com, rmk+kernel@arm.linux.org.uk, pavel.nakonechny@skitlab.ru, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: Fix cleanup resources upon module removal Message-ID: <20160308145230.GI351@lunn.ch> References: <20151207.163608.1805578623951785262.davem@davemloft.net> <1457429780-7665-1-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457429780-7665-1-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 14 On Tue, Mar 08, 2016 at 10:36:20AM +0100, Neil Armstrong wrote: > The initial commit badly merged into the dsa_resume method instead > of the dsa_remove_dst method. > As consequence, the dst->master_netdev->dsa_ptr is not set to NULL on > removal and re-bind of the dsa device fails with error -17. > > Fixes: b0dc635d923c ("net: dsa: cleanup resources upon module removal ") > Signed-off-by: Neil Armstrong Acked-by: Andrew Lunn Thanks Andrew