Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932671AbcCHPwc (ORCPT ); Tue, 8 Mar 2016 10:52:32 -0500 Received: from prod-mail-xrelay05.akamai.com ([23.79.238.179]:35243 "EHLO prod-mail-xrelay05.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbcCHPwP (ORCPT ); Tue, 8 Mar 2016 10:52:15 -0500 From: Joshua Hunt To: gong.chen@intel.com, linux-acpi@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, ying.huang@intel.com Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org, Joshua Hunt Subject: [PATCH v2 0/2] ACPI, APEI: Memory leaks Date: Tue, 8 Mar 2016 10:52:10 -0500 Message-Id: <1457452332-2673-1-git-send-email-johunt@akamai.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5642 Lines: 118 While investigating a possible memory leak using kmemleak I came across the following five leaks coming from APEI and ERST: unreferenced object 0xffff880402b6ee80 (size 32): comm "swapper/0", pid 1, jiffies 4294669373 (age 318.183s) hex dump (first 32 bytes): 58 fe ab fa 03 88 ff ff 58 fe ab fa 03 88 ff ff X.......X....... 18 50 ea dc 00 00 00 00 3f 50 ea dc 00 00 00 00 .P......?P...... backtrace: [] create_object+0x103/0x2c0 [] kmemleak_alloc+0x82/0xc0 [] kmem_cache_alloc_trace+0x17b/0x210 [] apei_res_add+0x19a/0x200 [] collect_res_callback+0x82/0xa0 [] apei_exec_for_each_entry+0x85/0xb0 [] apei_exec_collect_resources+0x1a/0x20 [] erst_init+0x3d6/0x3e5 [] do_one_initcall+0x19d/0x1d0 [] kernel_init_freeable+0x13d/0x1d6 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x42/0x70 [] 0xffffffffffffffff unreferenced object 0xffff880402b6ee40 (size 32): comm "swapper/0", pid 1, jiffies 4294670231 (age 317.326s) hex dump (first 32 bytes): 68 fe ab fa 03 88 ff ff 68 fe ab fa 03 88 ff ff h.......h....... b2 00 00 00 00 00 00 00 b3 00 00 00 00 00 00 00 ................ backtrace: [] create_object+0x103/0x2c0 [] kmemleak_alloc+0x82/0xc0 [] kmem_cache_alloc_trace+0x17b/0x210 [] apei_res_add+0x19a/0x200 [] collect_res_callback+0x9c/0xa0 [] apei_exec_for_each_entry+0x85/0xb0 [] apei_exec_collect_resources+0x1a/0x20 [] erst_init+0x3d6/0x3e5 [] do_one_initcall+0x19d/0x1d0 [] kernel_init_freeable+0x13d/0x1d6 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x42/0x70 [] 0xffffffffffffffff unreferenced object 0xffff880402b6ee20 (size 32): comm "swapper/0", pid 1, jiffies 4294672240 (age 315.317s) hex dump (first 32 bytes): 88 fd ab fa 03 88 ff ff 00 ee b6 02 04 88 ff ff ................ 00 d0 15 cd 00 00 00 00 00 40 16 cd 00 00 00 00 .........@...... backtrace: [] create_object+0x103/0x2c0 [] kmemleak_alloc+0x82/0xc0 [] kmem_cache_alloc_trace+0x17b/0x210 [] apei_res_add+0x19a/0x200 [] apei_get_res_callback+0x1a/0x20 [] acpi_nvs_for_each_region+0x2b/0x50 [] apei_resources_request+0x95/0x380 [] erst_init+0xe2/0x3e5 [] do_one_initcall+0x19d/0x1d0 [] kernel_init_freeable+0x13d/0x1d6 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x42/0x70 [] 0xffffffffffffffff unreferenced object 0xffff880402b6ee00 (size 32): comm "swapper/0", pid 1, jiffies 4294672400 (age 315.157s) hex dump (first 32 bytes): 20 ee b6 02 04 88 ff ff 88 fd ab fa 03 88 ff ff ............... 00 80 f3 dc 00 00 00 00 00 60 a9 dd 00 00 00 00 .........`...... backtrace: [] create_object+0x103/0x2c0 [] kmemleak_alloc+0x82/0xc0 [] kmem_cache_alloc_trace+0x17b/0x210 [] apei_res_add+0x19a/0x200 [] apei_get_res_callback+0x1a/0x20 [] acpi_nvs_for_each_region+0x2b/0x50 [] apei_resources_request+0x95/0x380 [] erst_init+0xe2/0x3e5 [] do_one_initcall+0x19d/0x1d0 [] kernel_init_freeable+0x13d/0x1d6 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x42/0x70 [] 0xffffffffffffffff unreferenced object 0xffff880402b6ede0 (size 32): comm "swapper/0", pid 1, jiffies 4294672863 (age 314.698s) hex dump (first 32 bytes): a8 fd ab fa 03 88 ff ff a8 fd ab fa 03 88 ff ff ................ 00 00 00 f8 00 00 00 00 00 00 00 fc 00 00 00 00 ................ backtrace: [] create_object+0x103/0x2c0 [] kmemleak_alloc+0x82/0xc0 [] kmem_cache_alloc_trace+0x17b/0x210 [] apei_res_add+0x19a/0x200 [] apei_get_res_callback+0x1a/0x20 [] pci_mmcfg_for_each_region+0x51/0x60 [] apei_resources_request+0x34a/0x380 [] erst_init+0xe2/0x3e5 [] do_one_initcall+0x19d/0x1d0 [] kernel_init_freeable+0x13d/0x1d6 [] kernel_init+0xe/0xf0 [] ret_from_fork+0x42/0x70 [] 0xffffffffffffffff The issue has been reported a handful of times upstream. Here is one of the previous reports: https://lkml.org/lkml/2013/8/11/149 This series resolves the reported leaks and kmemleak is clean with these patches applied. Changes from v1 as per Gong Chen's comments: * Use existing apei_resources_fini calls to do the cleanup * Update changelog in erst_init patch Joshua Hunt (2): ACPI, APEI: Fix leaked resources ACPI, APEI, ERST: Fixed leaked resources in erst_init drivers/acpi/apei/apei-base.c | 6 ++++-- drivers/acpi/apei/erst.c | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) -- 1.7.9.5