Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932611AbcCHRVM (ORCPT ); Tue, 8 Mar 2016 12:21:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58232 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbcCHRVK (ORCPT ); Tue, 8 Mar 2016 12:21:10 -0500 Date: Tue, 8 Mar 2016 09:21:08 -0800 From: Chris Leech To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: open-iscsi@googlegroups.com, Lee Duncan Subject: Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id Message-ID: <20160308172108.zkw32e5uzoau7oth@straylight.hirudinean.org> Mail-Followup-To: Chris Leech , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, open-iscsi@googlegroups.com, Lee Duncan References: <1455298733-18651-1-git-send-email-lduncan@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455298733-18651-1-git-send-email-lduncan@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 17 On Fri, Feb 12, 2016 at 09:38:53AM -0800, Lee Duncan wrote: > The scsi_transport_iscsi module already uses the ida_simple > routines for managing the target ID, if requested to do > so. This change replaces an ever-increasing atomic integer > that tracks the session ID itself with the ida_simple > family of routines. This means that the session ID > will be reclaimed and can be reused when the session > is freed. > > Note that no maximum is placed on this value, though > user-space currently only seems to use the lower 24-bits. > It seems better to handle this in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan Acked-by: Chris Leech