Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403AbcCHUFm (ORCPT ); Tue, 8 Mar 2016 15:05:42 -0500 Received: from mail-ig0-f194.google.com ([209.85.213.194]:36416 "EHLO mail-ig0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbcCHUFX (ORCPT ); Tue, 8 Mar 2016 15:05:23 -0500 MIME-Version: 1.0 In-Reply-To: <1457460530-17959-1-git-send-email-toshi.kani@hpe.com> References: <1457460530-17959-1-git-send-email-toshi.kani@hpe.com> Date: Tue, 8 Mar 2016 12:05:22 -0800 X-Google-Sender-Auth: hMMNRhFpreLtyiNLN03JK1C1u4I Message-ID: Subject: Re: [PATCH v2-UPDATE2 3/4] resource: Add device-managed insert/remove_resource() From: Linus Torvalds To: Toshi Kani Cc: Ingo Molnar , Borislav Petkov , Dan Williams , "Rafael J. Wysocki" , Andrew Morton , "linux-nvdimm@lists.01.org" , Linux ACPI , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 16 On Tue, Mar 8, 2016 at 10:08 AM, Toshi Kani wrote: > > Add device-managed implementaions of insert_resource() and > remove_resouce() functions. Can we get an example of the users and show how much this would actually help? insert_resource() is fairly unusual to begin with, and it should basically *never* be used by a driver at all (it's more of a bus thing). The patch doesn't look _wrong_, but it does look potentially largely pointless. Adding new interfaces to do things that aren't common enough to worry about is counter-productive, imho. Linus