Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbcCHUZQ (ORCPT ); Tue, 8 Mar 2016 15:25:16 -0500 Received: from mail-pa0-f65.google.com ([209.85.220.65]:33617 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcCHUZK (ORCPT ); Tue, 8 Mar 2016 15:25:10 -0500 Date: Wed, 9 Mar 2016 01:55:01 +0530 From: Saiyam Doshi To: Greg KH Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: android: Fixed coding style issues reported by checkpatch Message-ID: <20160308202501.GF4153@saiyam> References: <1457292633-3058-1-git-send-email-saiyamdoshi.in@gmail.com> <20160307012108.GA1642@kroah.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="GLp9dJVi+aaipsRk" Content-Disposition: inline In-Reply-To: <20160307012108.GA1642@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4666 Lines: 142 --GLp9dJVi+aaipsRk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 06, 2016 at 05:21:08PM -0800, Greg KH wrote: > You need to do only one thing per patch, please split this up into > multiple patches. Created two separate patches out of it having same logical change in each. > Also verify that these are all really needed, please always work against > linux-next, not Linus's kernel tree. In 'drivers/staging/android/TODO' checkpatch.pl cleanup mentioned. Also this patches are created from latest linux-next tree. How you get information about target kernel version for submitted patch? I mean in patch there is no information about kernel version from which the patch is created. --GLp9dJVi+aaipsRk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="0001-staging-android-Fixed-coding-style-issue-reported-by.patch" >From fd6a8ba1030fdcfc1efca9b377cd0957580708dd Mon Sep 17 00:00:00 2001 From: Saiyam Doshi Date: Wed, 9 Mar 2016 00:15:04 +0530 Subject: [PATCH 1/2] staging: android: Fixed coding style issue reported by checkpatch Alignment should match open parenthesis Signed-off-by: Saiyam Doshi --- drivers/staging/android/sync.c | 6 +++--- drivers/staging/android/sync.h | 2 +- drivers/staging/android/sync_debug.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index 3a8f210..4a64bdd 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -430,7 +430,7 @@ static unsigned int sync_file_poll(struct file *file, poll_table *wait) } static long sync_file_ioctl_merge(struct sync_file *sync_file, - unsigned long arg) + unsigned long arg) { int fd = get_unused_fd_flags(O_CLOEXEC); int err; @@ -500,7 +500,7 @@ static int sync_fill_fence_info(struct fence *fence, void *data, int size) } static long sync_file_ioctl_fence_info(struct sync_file *sync_file, - unsigned long arg) + unsigned long arg) { struct sync_file_info *info; __u32 size; @@ -552,7 +552,7 @@ out: } static long sync_file_ioctl(struct file *file, unsigned int cmd, - unsigned long arg) + unsigned long arg) { struct sync_file *sync_file = file->private_data; diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index d2a1734..625814b 100644 --- a/drivers/staging/android/sync.h +++ b/drivers/staging/android/sync.h @@ -192,7 +192,7 @@ struct sync_file *sync_file_create(const char *name, struct fence *fence); * new merged sync_file or NULL in case of error. */ struct sync_file *sync_file_merge(const char *name, - struct sync_file *a, struct sync_file *b); + struct sync_file *a, struct sync_file *b); /** * sync_file_fdget() - get a sync_file from an fd diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c index 5a7ec58..3327a34 100644 --- a/drivers/staging/android/sync_debug.c +++ b/drivers/staging/android/sync_debug.c @@ -105,7 +105,7 @@ static void sync_print_fence(struct seq_file *s, struct fence *fence, bool show) } if ((!fence || fence->ops->timeline_value_str) && - fence->ops->fence_value_str) { + fence->ops->fence_value_str) { char value[64]; bool success; @@ -153,7 +153,7 @@ static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj) } static void sync_print_sync_file(struct seq_file *s, - struct sync_file *sync_file) + struct sync_file *sync_file) { int i; -- 1.9.1 --GLp9dJVi+aaipsRk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="0002-staging-android-Fixed-coding-style-issue-reported-by.patch" >From 23573696f7dcc38d3182ed8da53525284ee83f6f Mon Sep 17 00:00:00 2001 From: Saiyam Doshi Date: Wed, 9 Mar 2016 00:28:45 +0530 Subject: [PATCH 2/2] staging: android: Fixed coding style issue reported by checkpatch spinlock_t definition without comment Signed-off-by: Saiyam Doshi --- drivers/staging/android/timed_gpio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index bcd9924..cede99a 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/timed_gpio.c @@ -28,6 +28,7 @@ struct timed_gpio_data { struct timed_output_dev dev; struct hrtimer timer; + /* lock protects gpio access while setting it's value */ spinlock_t lock; unsigned gpio; int max_timeout; -- 1.9.1 --GLp9dJVi+aaipsRk--