Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbcCHUob (ORCPT ); Tue, 8 Mar 2016 15:44:31 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34067 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbcCHUoX (ORCPT ); Tue, 8 Mar 2016 15:44:23 -0500 From: Rasmus Villemoes To: Byungho An Cc: Girish K S , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] net: sxgbe: fix error paths in sxgbe_platform_probe() Organization: D03 References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-5-git-send-email-linux@rasmusvillemoes.dk> X-Hashcash: 1:20:160308:netdev@vger.kernel.org::/tRiF8pRjdpKldqi:0000000000000000000000000000000000000000Azm X-Hashcash: 1:20:160308:bh74.an@samsung.com::tOWabkh7gWPxl3Kj:0000000000000000000000000000000000000000001LQk X-Hashcash: 1:20:160308:vipul.pandya@samsung.com::kWYYjG55D2nGPMf0:0000000000000000000000000000000000000459J X-Hashcash: 1:20:160308:linux-kernel@vger.kernel.org::Z7R4c6Ab1Ph8gieK:00000000000000000000000000000000086uF X-Hashcash: 1:20:160308:ks.giri@samsung.com::ZJxnZnRWsW9j7Ze/:0000000000000000000000000000000000000000007+7j Date: Tue, 08 Mar 2016 21:44:20 +0100 In-Reply-To: <1455048677-19882-5-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 9 Feb 2016 21:11:15 +0100") Message-ID: <8737s0d7iz.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 33 ping On Tue, Feb 09 2016, Rasmus Villemoes wrote: > We need to use post-decrement to ensure that irq_dispose_mapping is > also called on priv->rxq[0]->irq_no; moreover, if one of the above for > loops failed already at i==0 (so we reach one of these labels with > that value of i), we'll enter an essentially infinite loop of > out-of-bounds accesses. > > Signed-off-by: Rasmus Villemoes > --- > drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c > index b02eed12bfc5..73427e29df2a 100644 > --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c > +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c > @@ -155,11 +155,11 @@ static int sxgbe_platform_probe(struct platform_device *pdev) > return 0; > > err_rx_irq_unmap: > - while (--i) > + while (i--) > irq_dispose_mapping(priv->rxq[i]->irq_no); > i = SXGBE_TX_QUEUES; > err_tx_irq_unmap: > - while (--i) > + while (i--) > irq_dispose_mapping(priv->txq[i]->irq_no); > irq_dispose_mapping(priv->irq); > err_drv_remove: