Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbcCHVJJ (ORCPT ); Tue, 8 Mar 2016 16:09:09 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35151 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbcCHVJH (ORCPT ); Tue, 8 Mar 2016 16:09:07 -0500 Date: Tue, 8 Mar 2016 13:09:02 -0800 From: Eduardo Valentin To: Wei Ni Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] thermal: consistently use int for trip temp Message-ID: <20160308210900.GB8145@localhost.localdomain> References: <1456997626-28298-1-git-send-email-wni@nvidia.com> <56DD3A84.4080304@nvidia.com> <56DE45F7.6060307@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56DE45F7.6060307@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 30 On Tue, Mar 08, 2016 at 11:24:39AM +0800, Wei Ni wrote: > > > On 2016年03月07日 16:23, Wei Ni wrote: > > There had a build error in previous patch. > > Fixed it in this version. > > Please review it. > > Add CC: linux-pm@vger.kernel.org > > > > > Thanks. > > Wei. > > > > On 2016年03月03日 17:33, Wei Ni wrote: > >> The commit 17e8351a7739 consistently use int for temperature, > >> however it missed a few in trip temperature and thermal_core. > >> > >> In current codes, the trip->temperature used "unsigned long" > >> and zone->temperature used"int", if the temperature is negative > >> value, it will get wrong result when compare temperature with > >> trip temperature. > >> > >> This patch can fix it. > >> > >> Signed-off-by: Wei Ni Rui are you collecting this one? Acked-by: Eduardo Valentin