Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcCHVap (ORCPT ); Tue, 8 Mar 2016 16:30:45 -0500 Received: from lists.s-osg.org ([54.187.51.154]:37615 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbcCHVaf (ORCPT ); Tue, 8 Mar 2016 16:30:35 -0500 Subject: Re: [PATCH 1/3] thermal: exynos: List vtmu-supply as optional property in DT binding To: Eduardo Valentin References: <1455819551-4666-1-git-send-email-javier@osg.samsung.com> <1455819551-4666-2-git-send-email-javier@osg.samsung.com> <20160308210744.GA8145@localhost.localdomain> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Pawel Moll , Zhang Rui , Mark Rutland From: Javier Martinez Canillas Message-ID: <56DF4469.7090603@osg.samsung.com> Date: Tue, 8 Mar 2016 18:30:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160308210744.GA8145@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2144 Lines: 53 Hello Eduardo, On 03/08/2016 06:07 PM, Eduardo Valentin wrote: > On Thu, Feb 18, 2016 at 03:19:09PM -0300, Javier Martinez Canillas wrote: >> The Exynos Thermal Management Unit binding says that the vtmu-supply >> is optional but is listed in the required properties section. Add an >> optional properties section and move the regulator property there. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt >> index faa62059b5c5..70b4c16c7ed8 100644 >> --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt >> @@ -41,9 +41,6 @@ >> for current TMU channel >> -- "tmu_sclk" clock for functional operation of the current TMU >> channel >> -- vtmu-supply: This entry is optional and provides the regulator node supplying >> - voltage to TMU. If needed this entry can be placed inside >> - board/platform specific dts file. >> >> The Exynos TMU supports generating interrupts when reaching given >> temperature thresholds. Number of supported thermal trip points depends > > Where is this patch based on? I checked it on my fixes and linus > branches, also on linux-next 0308 branch, and none of those apply clean. > I mentioned in the cover letter [0] that this series were based on top of in-flight patches from Krzysztof Kozlowski to avoid merge conflicts. Those have not landed yet either so maybe you could look at those first? > Can you please send this based on upstream kernel? > Ok, my intention was to make picking both patch series easier but if this is inconvenient to you, I can base on top of current mainline and let you handle the merge conflicts (or ask Krzysztof to resend on top of my patches). [0]: https://lkml.org/lkml/2016/2/18/591 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America