Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbcCIEJ1 (ORCPT ); Tue, 8 Mar 2016 23:09:27 -0500 Received: from mail-oi0-f43.google.com ([209.85.218.43]:36806 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbcCIEJ0 (ORCPT ); Tue, 8 Mar 2016 23:09:26 -0500 MIME-Version: 1.0 In-Reply-To: <1456934350-1389172-2-git-send-email-arnd@arndb.de> References: <1456934350-1389172-1-git-send-email-arnd@arndb.de> <1456934350-1389172-2-git-send-email-arnd@arndb.de> Date: Wed, 9 Mar 2016 11:09:25 +0700 Message-ID: Subject: Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions From: Linus Walleij To: Arnd Bergmann Cc: Ludovic Desroches , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 18 On Wed, Mar 2, 2016 at 10:58 PM, Arnd Bergmann wrote: > The at91-pio4 pinctrl driver uses SET_SYSTEM_SLEEP_PM_OPS() to > conditionally set the correct suspend/resume options, but they > become unused when CONFIG_PM is disabled: > > drivers/pinctrl/pinctrl-at91-pio4.c:827:12: error: 'atmel_pctrl_suspend' defined but not used [-Werror=unused-function] > drivers/pinctrl/pinctrl-at91-pio4.c:847:12: error: 'atmel_pctrl_resume' defined but not used [-Werror=unused-function] > > This adds __maybe_unused annotations so the compiler knows > it can silently drop them instead of warning. > > Signed-off-by: Arnd Bergmann Patch applied with the maintainer ACKs. Yours, Linus Walleij