Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbcCIGSe (ORCPT ); Wed, 9 Mar 2016 01:18:34 -0500 Received: from foss.arm.com ([217.140.101.70]:37637 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbcCIGS1 (ORCPT ); Wed, 9 Mar 2016 01:18:27 -0500 Subject: Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure To: Christoffer Dall References: <1457436573-6180-1-git-send-email-julien.grall@arm.com> <1457436573-6180-4-git-send-email-julien.grall@arm.com> <20160309054710.GI26583@lvm> Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, fu.wei@linaro.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wei@redhat.com, al.stone@linaro.org, Thomas Gleixner , Jason Cooper From: Julien Grall Message-ID: <56DFC026.5020909@arm.com> Date: Wed, 9 Mar 2016 13:18:14 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160309054710.GI26583@lvm> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 43 Hi Christoffer, On 09/03/2016 12:47, Christoffer Dall wrote: > On Tue, Mar 08, 2016 at 11:29:27AM +0000, Julien Grall wrote: >> For now, there is only one member. More member will be added later. > > questionable commit message What about: "The ACPI code requires to use global variables in order to collect information from the tables. For now only a single global variable is used, but more will be added in a subsequent patch. To make clear they are ACPI specific, gather all the information in a single structure." [...] >> @@ -1316,7 +1319,7 @@ static int __init gic_v2_acpi_init(struct acpi_subtable_header *header, >> return -EINVAL; >> } >> >> - cpu_base = ioremap(cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE); >> + cpu_base = ioremap(acpi_data.cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE); >> if (!cpu_base) { >> pr_err("Unable to map GICC registers\n"); >> return -ENOMEM; >> -- >> 1.9.1 >> > super nit: I would use cpu_phys_base instead of cpu_phy_base, but I'll > leave it up to you. I will update the commit message, so I will rename the variable too. > > Acked-by: Christoffer Dall Cheers, -- Julien Grall