Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbcCIHz1 (ORCPT ); Wed, 9 Mar 2016 02:55:27 -0500 Received: from mail-ig0-f193.google.com ([209.85.213.193]:33632 "EHLO mail-ig0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbcCIHzS (ORCPT ); Wed, 9 Mar 2016 02:55:18 -0500 MIME-Version: 1.0 In-Reply-To: <1457333940-13076-1-git-send-email-shawn.lin@rock-chips.com> References: <1457333940-13076-1-git-send-email-shawn.lin@rock-chips.com> Date: Wed, 9 Mar 2016 14:55:17 +0700 X-Google-Sender-Auth: DQkegtNQGunidKeRq-f7VH-DoIM Message-ID: Subject: Re: [RESENT PATCH] mmc: block: fix ABI regression of mmc_blk_ioctl From: John Stultz To: Shawn Lin Cc: Ulf Hansson , Seshagiri Holi , Jon Hunter , linux-mmc@vger.kernel.org, Linux Kernel Mailing List , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 24 On Mon, Mar 7, 2016 at 1:59 PM, Shawn Lin wrote: > We should return -EINVAL if cmd is not MMC_IOC_CMD or MMC_IOC_MULTI_CMD, > otherwise blkdev_roset will return -EPERM. > > Android-adb calls make_block_device_writable with ioctl(BLKROSET), which > will return error, make remount failed: > remount of /system failed; > couldn't make block device writable: Operation not permitted > > openat(AT_FDCWD, "/dev/block/platform/ff420000.dwmmc/by-name/system", O_RDONLY) = 3 > ioctl(3, BLKROSET, 0) = -1 EPERM (Operation not permitted) > > Fixes: a5f5774c55a2 ("mmc: block: Add new ioctl to send multi commands") > Cc: stable@vger.kernel.org > Signed-off-by: Shawn Lin Ulf, We're hitting this as well, and Shawn's patch seems to fix it for me. Tested-by: John Stultz Thanks Shawn! -john