Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbcCIIsP (ORCPT ); Wed, 9 Mar 2016 03:48:15 -0500 Received: from regular1.263xmail.com ([211.150.99.139]:40444 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbcCIIsE (ORCPT ); Wed, 9 Mar 2016 03:48:04 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhangqing@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhangqing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56DFE22A.9090502@rock-chips.com> Date: Wed, 09 Mar 2016 16:43:22 +0800 From: Elaine Zhang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Caesar Wang , wxt@rock-chips.com CC: heiko@sntech.de, khilman@baylibre.com, huangtao@rock-chips.com, xxx@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 4/6] dt/bindings: power: add RK3399 SoCs header for power-domain References: <1456992233-25164-1-git-send-email-zhangqing@rock-chips.com> <1456992233-25164-5-git-send-email-zhangqing@rock-chips.com> <56DEAD32.7090405@gmail.com> In-Reply-To: <56DEAD32.7090405@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2457 Lines: 88 On 03/08/2016 06:45 PM, Caesar Wang wrote: > > > 在 2016年03月03日 16:03, Elaine Zhang 写道: >> According to a description from TRM, add all the power domains >> >> Signed-off-by: Elaine Zhang >> --- >> include/dt-bindings/power/rk3399-power.h | 53 >> ++++++++++++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 include/dt-bindings/power/rk3399-power.h >> >> diff --git a/include/dt-bindings/power/rk3399-power.h >> b/include/dt-bindings/power/rk3399-power.h >> new file mode 100644 >> index 0000000..69fbd67 >> --- /dev/null >> +++ b/include/dt-bindings/power/rk3399-power.h >> @@ -0,0 +1,53 @@ >> +#ifndef __DT_BINDINGS_POWER_RK3399_POWER_H__ >> +#define __DT_BINDINGS_POWER_RK3399_POWER_H__ >> + >> +/* VD_CORE_L */ >> +#define RK3399_PD_A53_L0 0 >> +#define RK3399_PD_A53_L1 1 >> +#define RK3399_PD_A53_L2 2 >> +#define RK3399_PD_A53_L3 3 >> +#define RK3399_PD_SCU_L 4 >> + >> +/* VD_CORE_B */ >> +#define RK3399_PD_A72_B0 5 >> +#define RK3399_PD_A72_B1 6 >> +#define RK3399_PD_SCU_B 7 >> + >> +/* VD_CENTER */ >> +#define RK3399_PD_CENTER 8 >> +#define RK3399_PD_VCODEC 9 >> +#define RK3399_PD_RGA 10 >> +#define RK3399_PD_IEP 11 >> +#define RK3399_PD_VDU 12 >> + >> +/* VD_LOGIC */ >> +#define RK3399_PD_PERILP 13 >> +#define RK3399_PD_PERIHP 14 >> +#define RK3399_PD_VIO 15 >> +#define RK3399_PD_VO 16 > ... > ISP? #define RK3399_PD_ISP0 19 #define RK3399_PD_ISP1 20 >> +#define RK3399_PD_VOPB 17 >> +#define RK3399_PD_VOPL 18 >> +#define RK3399_PD_ISP0 19 >> +#define RK3399_PD_ISP1 20 >> +#define RK3399_PD_HDCP 21 >> +#define RK3399_PD_TCPD0 22 >> +#define RK3399_PD_TCPD1 23 >> +#define RK3399_PD_GIC 24 >> +#define RK3399_PD_ALIVE 25 >> +#define RK3399_PD_USB3 26 >> +#define RK3399_PD_SD 27 >> +#define RK3399_PD_CCI 28 >> +#define RK3399_PD_CCI0 29 >> +#define RK3399_PD_CCI1 30 >> +#define RK3399_PD_GMAC 31 >> +#define RK3399_PD_EMMC 32 >> +#define RK3399_PD_EDP 33 >> +#define RK3399_PD_SDIOAUDIO 34 >> + >> +/* VD_GPU */ >> +#define RK3399_PD_GPU 35 >> + >> +/* VD_PMU */ >> +#define RK3399_PD_PMU 36 >> + > > Would you please follow the TRM? Our pd group according to the voltage domain.Not nedd to follow the TRM. > > > >> +#endif > >