Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbcCIIxL (ORCPT ); Wed, 9 Mar 2016 03:53:11 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:50759 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcCIIxC (ORCPT ); Wed, 9 Mar 2016 03:53:02 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhangqing@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhangqing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56DFE35F.3010400@rock-chips.com> Date: Wed, 09 Mar 2016 16:48:31 +0800 From: Elaine Zhang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Caesar Wang , wxt@rock-chips.com CC: heiko@sntech.de, khilman@baylibre.com, huangtao@rock-chips.com, xxx@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 5/6] dt/bindings: rockchip: modify document of Rockchip power domains References: <1456992233-25164-1-git-send-email-zhangqing@rock-chips.com> <1456992557-25331-1-git-send-email-zhangqing@rock-chips.com> <56DEB2E1.6060808@gmail.com> In-Reply-To: <56DEB2E1.6060808@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 59 On 03/08/2016 07:09 PM, Caesar Wang wrote: > > > 在 2016年03月03日 16:09, Elaine Zhang 写道: >> Add binding documentation for the power domains >> found on Rockchip RK3399 SoCs. >> RK3399 pd on/off not need to enable clk which in this pd. >> So remove the clocks in the rk3399 pd example. >> >> Signed-off-by: Elaine Zhang >> --- >> .../bindings/soc/rockchip/power_domain.txt | 37 >> ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> index 13dc6a3..98085c8 100644 >> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> @@ -7,6 +7,7 @@ Required properties for power domain controller: >> - compatible: Should be one of the following. > [....] >> Example of the node using power domain: >> @@ -65,3 +96,9 @@ Example of the node using power domain: >> power-domains = <&power RK3368_PD_GPU_1>; >> /* ... */ >> }; >> + >> + node { >> + /* ... */ >> + power-domains = <&power RK3399_PD_VOPB>; >> + /* ... */ >> + }; > > Trivial: typo > power: power-controller { > @@ -92,10 +92,10 @@ Example of the node using power domain: > }; > > node { > - /* ... */ > - power-domains = <&power RK3368_PD_GPU_1>; > - /* ... */ > - }; > + /* ... */ > + power-domains = <&power RK3368_PD_GPU_1>; > + /* ... */ > + }; This is a example.I think there is no problem. > > > > >