Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753381AbcCIKyE (ORCPT ); Wed, 9 Mar 2016 05:54:04 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:33712 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbcCIKxw (ORCPT ); Wed, 9 Mar 2016 05:53:52 -0500 MIME-Version: 1.0 In-Reply-To: <56DFFA9E.7060602@st.com> References: <1457294038-14243-1-git-send-email-afaerber@suse.de> <56DD7172.4000707@suse.de> <2714888.1DdqvJZ8cb@diego> <56DD7593.5060003@suse.de> <56DD8176.2080603@st.com> <56DD8FBE.9010200@suse.de> <56DD99A4.5030004@st.com> <56DDA26C.3050301@suse.de> <56DDA3D5.3090209@st.com> <56DDB749.1020808@suse.de> <56DE7E1D.5070508@st.com> <56DFE55B.2090806@st.com> <56DFE64B.8060606@st.com> <56DFF253.9050208@st.com> <56DFFA9E.7060602@st.com> From: Tomeu Vizoso Date: Wed, 9 Mar 2016 11:53:29 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement To: Giuseppe CAVALLARO Cc: Fabrice GASNIER , Dinh Nguyen , "devicetree@vger.kernel.org" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , netdev@vger.kernel.org, "open list:ARM/Rockchip SoC..." , LAKML , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Gabriel Fernandez , Alexandre TORGUE , =?UTF-8?Q?Frank_Sch=C3=A4fer?= , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1939 Lines: 52 On 9 March 2016 at 11:27, Giuseppe CAVALLARO wrote: > Hello Tomeu, Andreas, > > On 3/9/2016 10:52 AM, Giuseppe CAVALLARO wrote: >>> >>> * today's linux-next: probe failed >>> >>> * today's linux-next + revert of 88f8b1bb41c6 stmmac: Fix 'eth0: No >>> PHY found' regression: probe succeeded but no network at all >>> >>> * today's linux-next + revert of 88f8b1bb41c6 (stmmac: Fix 'eth0: No >>> PHY found' regression) + revert of 0e80bdc9a72d (stmmac: first frame >>> prep at the end of xmit routine): probe succeeded, dhcp succeeds and >>> nfsroot works for a few seconds before timing out >> >> >> ok, I was looking at this problem now that seems to related >> the "stmmac: first frame prep at the end of xmit routine" >> that, at first glance, is breaking the gmac 3.50 with normal descriptor. > > > I have no Hw where to test this use case. So, I wonder if may I ask you to > test some patch. > > This first patch adds a missing barrier to the normal routine that inits the > descriptor. Barrier was needed to well manage the OWN > descriptor and it was not added in case of normal desc case after > the xmit rework. > > Then I will check the algo behind the new xmit and in case of problems, > if you agree, we will decide to revert it because it aimed to add an > optimization. > > Let me know if you agree. I'm not sure what you would like to be tested, but just in case, I have just tried your patch on top of these commits and the result is the "transmit queue 0 timed out" error during boot: 6542b30d0a67 Revert "stmmac: first frame prep at the end of xmit routine" eb5274cbc0f7 Revert "stmmac: do not poll phy handler when attach a switch" e88e625a68d9 Revert "stmmac: fix phy init when attached to a phy" ef5dd3777876 stmmac: fix MDIO settings 77634ba1f25c Revert "stmmac: Fix 'eth0: No PHY found' regression" 7811b4ffc312 Add linux-next specific files for 20160309 Regards, Tomeu > Regards > Peppe