Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbcCILV0 (ORCPT ); Wed, 9 Mar 2016 06:21:26 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:52827 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbcCILVI (ORCPT ); Wed, 9 Mar 2016 06:21:08 -0500 Subject: Re: [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine) To: "Wei Hu(Xavier)" , , , , , , , , , , , , , , , , , , , References: <1457080877-13456-1-git-send-email-xavier.huwei@huawei.com> <1457080877-13456-2-git-send-email-xavier.huwei@huawei.com> <20160306142516.GE13396@leon.nu> From: oulijun Message-ID: <56E006EB.6070108@huawei.com> Date: Wed, 9 Mar 2016 19:20:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160306142516.GE13396@leon.nu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.25.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.56E006FB.0127,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8e8759fa5e7fc1a222d612de6455d8d3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2596 Lines: 83 Hi, dledford thanks your reviewing. I will send a new patch soon. thanks Lijun Ou On 2016/3/6 22:25, Leon Romanovsky wrote: > Please rewrite your title to be without (...). > > On Fri, Mar 04, 2016 at 04:41:14PM +0800, Wei Hu(Xavier) wrote: >> It added hns_dsaf_roce_reset routine for roce driver. >> RoCE is a feature of hns. >> In hip06 SOC, in roce reset process, it's needed to configure >> dsaf channel reset,port and sl map info. >> >> Signed-off-by: Wei Hu(Xavier) >> Signed-off-by: Lisheng >> Signed-off-by: oulijun >> --- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 82 ++++++++++++++++++++++ >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 7 ++ >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 62 +++++++++++++--- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 14 ++++ >> 4 files changed, 155 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c >> index 9439f04..41ba948 100644 >> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c >> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c >> @@ -12,6 +12,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -2556,6 +2557,87 @@ static struct platform_driver g_dsaf_driver = { >> >> module_platform_driver(g_dsaf_driver); >> >> +/** >> + * hns_dsaf_roce_reset - reset dsaf and roce >> + * @dsaf_fwnode: Pointer to framework node for the dasf >> + * @val: 0 - request reset , 1 - drop reset >> + * retuen 0 - success , negative --fail >> + */ >> +int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, u32 val) >> +{ >> + struct dsaf_device *dsaf_dev; >> + struct platform_device *pdev; >> + unsigned int mp; >> + unsigned int sl; >> + unsigned int credit; >> + int i; >> + const u32 port_map[DSAF_ROCE_CREDIT_CHN][DSAF_ROCE_CHAN_MODE] = { >> + {0, 0, 0}, >> + {1, 0, 0}, >> + {2, 1, 0}, >> + {3, 1, 0}, >> + {4, 2, 1}, >> + {4, 2, 1}, >> + {5, 3, 1}, >> + {5, 3, 1}, >> + }; >> + const u32 sl_map[DSAF_ROCE_CREDIT_CHN][DSAF_ROCE_CHAN_MODE] = { >> + {0, 0, 0}, >> + {0, 1, 1}, >> + {0, 0, 2}, >> + {0, 1, 3}, >> + {0, 0, 0}, >> + {1, 1, 1}, >> + {0, 0, 2}, >> + {1, 1, 3}, >> + }; > > Please prefer enums/defines instead of hard coded values. > it is applicable to whole submitted code. > > > . >