Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbcCILjT (ORCPT ); Wed, 9 Mar 2016 06:39:19 -0500 Received: from mga03.intel.com ([134.134.136.65]:8400 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbcCILjS (ORCPT ); Wed, 9 Mar 2016 06:39:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,311,1455004800"; d="asc'?scan'208";a="920105929" From: Felipe Balbi To: "Nicholas A. Bellinger" Cc: Dan Carpenter , Christoph Hellwig , Greg Kroah-Hartman , Sebastian Andrzej Siewior , Andrzej Pietrasiewicz , Bart Van Assche , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [patch -target tree] usb: gadget: f_tcm: use after free In-Reply-To: <1457162818.19657.282.camel@haakon3.risingtidesystems.com> References: <20160302100848.GC5533@mwanda> <87k2ll856m.fsf@ti.com> <1457162818.19657.282.camel@haakon3.risingtidesystems.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 09 Mar 2016 13:38:24 +0200 Message-ID: <8737rzg9u7.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 62 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, "Nicholas A. Bellinger" writes: > [ text/plain ] > Hi Felipe + usb-gadget folks, > > On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: >> Dan Carpenter writes: >> > We need to move the kfree() down a line so we don't dereference a freed >> > variable. >> > >> > Fixes: 1b418a8fcbc0 ('target: Convert demo-mode only drivers to target= _alloc_session') >> > Signed-off-by: Dan Carpenter >>=20 >> It's okay to take this via target: >>=20 >> Signed-off-by: Felipe Balbi >>=20 > > Note this specific patch is only a mechanical change, and we still need > reviews for the more interesting conversions: > > usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation > http://www.spinics.net/lists/target-devel/msg11777.html > > usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs > http://www.spinics.net/lists/target-devel/msg11782.html > I don't have either patch in my inbox apparently. Care to resend ? sorry =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW4AswAAoJEIaOsuA1yqREVuIP/3lOQ3J6Whq5ZyldTaGVLQi7 peDaiWWLCVATAcPInNcWKE02roFbXd9vtDAllt45Xw1TfqCwXgXKZjzNO0JBtPnm FT0zlSyVivkUvhi1SxaDEg3NRdS4L9bAZXsZvEsRm6RswtaIj+TuOkO4rA6e667X QjwvS3t+pPUSVvf2XBisqL3ZrOjq6259eV5TQR+qDuWC5iHS3oTheHlBmP8hDxzI ZWd6pVKma030dRk+9w0w22x/29215YRxwOTxsBZP4f7K7rgvFOgajfmqzwBbd0o1 5i8IMyGsPoB1r7WyGNYBDvLFCQfcXB0lzYXMPwUOEZPxETlVcP8c2oqpAP9BFddb 3cKs/cREIQVtR7yAseNkngqJhQuJi2VJiMfPXV3t2eOIn4EnL/ZZ4JonFQIlSZp9 XO6jRSmauvaAAGUhBzfCCpMt3dUBf8LjANtGOzmUHzfNZVzCiJwqlxgOqIG6uq8f Nn4MEFZE4k7Fk8v/UvUi2UVC5c1UvAHAeCQsbPNpe4CeYHhwAGCsbz9Jah9kC4Pu vSbyombCsQBqHnQaHk9XGQwB5X3m8hZw9IotYpTfLfT57PhYtPOtge4+gRxLxAef 0ZzEGzHVQef1DqaUAKZrj4BoIxzFA/9eHlpUdUJn6/PGp363acF1TyGWdCoN+6Jp OOtKuvoZ2A7nQFP/Qcec =Dg6Q -----END PGP SIGNATURE----- --=-=-=--