Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S261828AbTCLXso>; Wed, 12 Mar 2003 18:48:44 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262128AbTCLXso>; Wed, 12 Mar 2003 18:48:44 -0500
Received: from pc2-cwma1-4-cust86.swan.cable.ntl.com ([213.105.254.86]:13513
	"EHLO irongate.swansea.linux.org.uk") by vger.kernel.org with ESMTP
	id <S261828AbTCLXsj>; Wed, 12 Mar 2003 18:48:39 -0500
Subject: Re: Problem with aacraid driver in 2.5.63-bk-latest
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: dougg@torque.net
Cc: Mark Haverkamp <markh@osdl.org>,
       Christoffer Hall-Frederiksen <hall@jiffies.dk>,
       linux-scsi@vger.kernel.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       linux aacraid devel <linux-aacraid-devel@dell.com>
In-Reply-To: <3E6FC8D6.7090005@torque.net>
References: <20030228133037.GB7473@jiffies.dk>
	 <1047510381.12193.28.camel@markh1.pdx.osdl.net>
	 <1047514681.23725.35.camel@irongate.swansea.linux.org.uk>
	 <3E6FC8D6.7090005@torque.net>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: 
Message-Id: <1047517604.23902.39.camel@irongate.swansea.linux.org.uk>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.1 (1.2.1-4) 
Date: 13 Mar 2003 01:06:44 +0000
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 822
Lines: 19

On Wed, 2003-03-12 at 23:55, Douglas Gilbert wrote:
>          /*
>           * Limit max queue depth on a single lun to 256 for now.  Remember,
>           * we allocate a struct scsi_command for each of these and keep it
>           * around forever.  Too deep of a depth just wastes memory.
>           */
>          if(tags > 256)
>                  return;
> ....

I can see the memory consideration. However the thing can really handle big
queues well. Possibly we should be setting the queue to 512 / somefunction(volumes)
though to avoid the worst case overcommit here

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/