Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933221AbcCIQNG (ORCPT ); Wed, 9 Mar 2016 11:13:06 -0500 Received: from lists.s-osg.org ([54.187.51.154]:39426 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753708AbcCIQND (ORCPT ); Wed, 9 Mar 2016 11:13:03 -0500 Subject: Re: [RFC PATCH v1 0/9] Tests for sync infrastructure To: =?UTF-8?Q?Emilio_L=c3=b3pez?= References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> Cc: devel@driverdev.osuosl.org, Gustavo Padovan , Riley Andrews , Daniel Vetter , John Harrison , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Hackmann , Rob Clark , linux-kselftest@vger.kernel.org, Maarten Lankhorst , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <56E04B8C.7000504@osg.samsung.com> Date: Wed, 9 Mar 2016 09:13:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3706 Lines: 84 On 03/09/2016 08:28 AM, Emilio López wrote: > Hello everyone, > > This is a series of tests to exercise the sync kernel infrastructure. It is > meant to be a test suite for the work Gustavo has been doing to destage it, > see [0] for his latest series to date. > > These tests were originally part of a battery of tests shipping with > Android's libsync that were rewritten to use the new userspace interfaces. > > As usual, all comments are welcome. > > Cheers! > Emilio > > [0] https://lists.freedesktop.org/archives/dri-devel/2016-March/102204.html Good to see this suite added to Kselftest. Thanks for being thorough and including .gitignore. Are there any destructive and/or longer time tests in this suite. If so could you please make them optional to run. Please see selftests/timers as an example for excluding. More comments on individual patches to follow. thanks, -- Shuah > > > Emilio López (9): > selftest: sync: basic tests for sw_sync framework > selftest: sync: fence tests for sw_sync framework > selftest: sync: merge tests for sw_sync framework > selftest: sync: wait tests for sw_sync framework > selftest: sync: destruction tests for sw_sync framework > selftest: sync: stress test for parallelism > selftest: sync: stress consumer/producer test > selftest: sync: stress test for merges > selftest: sync: disable tests that rely on not yet defined behaviour > > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/sync/.gitignore | 1 + > tools/testing/selftests/sync/Makefile | 28 +++ > tools/testing/selftests/sync/sw_sync.h | 46 +++++ > tools/testing/selftests/sync/sync.c | 203 +++++++++++++++++++++ > tools/testing/selftests/sync/sync.h | 119 ++++++++++++ > tools/testing/selftests/sync/sync_alloc.c | 74 ++++++++ > tools/testing/selftests/sync/sync_destroyed.c | 90 +++++++++ > tools/testing/selftests/sync/sync_fence.c | 134 ++++++++++++++ > tools/testing/selftests/sync/sync_merge.c | 60 ++++++ > .../testing/selftests/sync/sync_stress_consumer.c | 185 +++++++++++++++++++ > tools/testing/selftests/sync/sync_stress_merge.c | 115 ++++++++++++ > .../selftests/sync/sync_stress_parallelism.c | 111 +++++++++++ > tools/testing/selftests/sync/sync_test.c | 87 +++++++++ > tools/testing/selftests/sync/sync_wait.c | 95 ++++++++++ > tools/testing/selftests/sync/synctest.h | 69 +++++++ > 16 files changed, 1418 insertions(+) > create mode 100644 tools/testing/selftests/sync/.gitignore > create mode 100644 tools/testing/selftests/sync/Makefile > create mode 100644 tools/testing/selftests/sync/sw_sync.h > create mode 100644 tools/testing/selftests/sync/sync.c > create mode 100644 tools/testing/selftests/sync/sync.h > create mode 100644 tools/testing/selftests/sync/sync_alloc.c > create mode 100644 tools/testing/selftests/sync/sync_destroyed.c > create mode 100644 tools/testing/selftests/sync/sync_fence.c > create mode 100644 tools/testing/selftests/sync/sync_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_consumer.c > create mode 100644 tools/testing/selftests/sync/sync_stress_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_parallelism.c > create mode 100644 tools/testing/selftests/sync/sync_test.c > create mode 100644 tools/testing/selftests/sync/sync_wait.c > create mode 100644 tools/testing/selftests/sync/synctest.h > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978