Subject: Re: [RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not
 yet defined behaviour
To: =?UTF-8?Q?Emilio_L=c3=b3pez?= <emilio.lopez@collabora.co.uk>
References: <1457537342-678-1-git-send-email-emilio.lopez@collabora.co.uk>
 <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk>
Cc: devel@driverdev.osuosl.org,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        John Harrison <John.C.Harrison@Intel.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Greg Hackmann <ghackmann@google.com>, Rob Clark <robdclark@gmail.com>,
        linux-kselftest@vger.kernel.org,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Daniel Stone <daniels@collabora.com>,
        =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= <arve@android.com>,
        Shuah Khan <shuahkh@osg.samsung.com>
From: Shuah Khan <shuahkh@osg.samsung.com>
Organization: Samsung Open Source Group
Message-ID: <56E04BD6.9050502@osg.samsung.com>
Date: Wed, 9 Mar 2016 09:14:14 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1457537342-678-10-git-send-email-emilio.lopez@collabora.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1649
Lines: 47

On 03/09/2016 08:29 AM, Emilio López wrote:
> One of the tests rely on a behaviour only observed on the driver currently
> in use in Android. Disable it here until the behaviour is implemented
> or it is decided it should not be implemented on the driver in mainline.
> 
> Signed-off-by: Emilio López <emilio.lopez@collabora.co.uk>
> 
> ---
> 
>  tools/testing/selftests/sync/sync_test.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
> index c3e4c01..3f484318 100644
> --- a/tools/testing/selftests/sync/sync_test.c
> +++ b/tools/testing/selftests/sync/sync_test.c
> @@ -66,7 +66,14 @@ int main(void)
>  	err += RUN_TEST(test_fence_one_timeline_merge);
>  	err += RUN_TEST(test_fence_merge_same_fence);
>  	err += RUN_TEST(test_fence_multi_timeline_wait);
> +#if 0
> +	/* The following test has been disabled due to differences
> +	 * between the upstream and Android kernel drivers. The behaviour
> +	 * that should occur when destroying a timeline with active fences
> +	 * has not been defined yet.
> +	 */
>  	err += RUN_TEST(test_fence_wait_on_destroyed_timeline);
> +#endif

It would be useful to have a real define here that can be
enabled later easily instead of if 0.

thanks,
-- Shuah

>  	err += RUN_TEST(test_stress_two_threads_shared_timeline);
>  	err += RUN_TEST(test_consumer_stress_multi_producer_single_consumer);
>  	err += RUN_TEST(test_merge_stress_random_merge);
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978