Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933381AbcCIQkn (ORCPT ); Wed, 9 Mar 2016 11:40:43 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:36284 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933176AbcCIQkf (ORCPT ); Wed, 9 Mar 2016 11:40:35 -0500 Date: Wed, 9 Mar 2016 10:40:23 -0600 From: Chris J Arges To: Josh Poimboeuf Cc: Petr Mladek , Jiri Kosina , Jessica Yu , Miroslav Benes , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: Fix the error message about unresolvable ambiguity Message-ID: <20160309164004.GA30562@canonical.com> References: <1457533259-6138-1-git-send-email-pmladek@suse.com> <20160309161946.GC21308@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160309161946.GC21308@treble.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1704 Lines: 44 On Wed, Mar 09, 2016 at 10:19:46AM -0600, Josh Poimboeuf wrote: > On Wed, Mar 09, 2016 at 03:20:59PM +0100, Petr Mladek wrote: > > klp_find_callback() stops the search when sympos is not defined and > > a second symbol of the same name is found. It means that the current > > error message about the unresolvable ambiguity always prints "(2 matches)". > > > > Let's remove this information. The total number of occurrences is > > not much helpful. The author of the patch still must put a non-trivial > > effort into searching the right position in the object file. > > > > Signed-off-by: Petr Mladek > > --- > > kernel/livepatch/core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > index bc2c85c064c1..f2eda09e8357 100644 > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -190,8 +190,8 @@ static int klp_find_object_symbol(const char *objname, const char *name, > > if (args.addr == 0) > > pr_err("symbol '%s' not found in symbol table\n", name); > > else if (args.count > 1 && sympos == 0) { > > - pr_err("unresolvable ambiguity (%lu matches) on symbol '%s' in object '%s'\n", > > - args.count, name, objname); > > + pr_err("unresolvable ambiguity on symbol '%s' in object '%s'\n", > > While you're at it, can you improve the grammar: s/on/for/ ? > > "unresolvable ambiguity *for* symbol..." > > Either way, > > Acked-by: Josh Poimboeuf > > -- > Josh > I agree that the 'matches' error message doesn't added anything helpful. With the word change above: Acked-by: Chris J Arges --chris