Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933417AbcCIQ6k (ORCPT ); Wed, 9 Mar 2016 11:58:40 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:33649 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbcCIQ6b (ORCPT ); Wed, 9 Mar 2016 11:58:31 -0500 MIME-Version: 1.0 In-Reply-To: <56E04E2A.5070205@ti.com> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <56E04E2A.5070205@ti.com> Date: Wed, 9 Mar 2016 16:58:29 +0000 Message-ID: Subject: Re: [PATCH 00/23] Nokia N950 display support From: Emil Velikov To: Tomi Valkeinen Cc: Sebastian Reichel , Tony Lindgren , Aaro Koskinen , linux-omap@vger.kernel.org, Laurent Pinchart , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 37 On 9 March 2016 at 16:24, Tomi Valkeinen wrote: > On 09/03/16 18:19, Emil Velikov wrote: >> Hi Sebastian, >> >> On 8 March 2016 at 16:39, Sebastian Reichel wrote: >> >>> arch/arm/boot/dts/omap3-n950-n9.dtsi | 72 +++++++++ >>> arch/arm/boot/dts/omap3-n950.dts | 71 +++++++++ >> Just a friendly reminder that updating these and one will have to keep >> the driver backwards compatible forever. >> >> Tomi, has been in the process of removing all the unneeded cruft, >> although omapdrm it is still using the custom panel, dsi and other >> code as opposed to the ones provided by DRM. As he gets to reusing >> those he might have some fun keeping things compatible. >> >> It's up-to Tomi to decide, just thought I point it out. > > I haven't looked at this series yet, but all the omap display DT > bindings have been designed to be correct, and while omapdrm will > receive lots of changes, I don't see any need to touch anything in the > DT side. > > Of course, if we will be using some existing common driver which > implements bindings in some other way, it'll cause some complexities... > I'm leaning that you want to use the existing the DRM_PANEL driver (gpu/drm/drm_panel.c). It has enough infrastructure to support 25+ 'simple' panels (gpu/drm/panel/panel-simple.c) plus 5+ more complex ones (gpu/drm/panel/). >From a quick look the binding, they do differ although do take a look for yourself: Documentation/devicetree/bindings/display/panel/{display-timing,panel-dpi,panel-dsi-cm,simple-panel}.txt Regards, Emil