Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933493AbcCIRSS (ORCPT ); Wed, 9 Mar 2016 12:18:18 -0500 Received: from casper.infradead.org ([85.118.1.10]:39069 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933310AbcCIRSL (ORCPT ); Wed, 9 Mar 2016 12:18:11 -0500 Subject: Re: linux-next: Tree for Mar 9 (net: bpf) To: Daniel Borkmann , Stephen Rothwell , linux-next@vger.kernel.org References: <20160309163852.4dd159b1@canb.auug.org.au> <56E052E4.90504@infradead.org> <56E053D3.7090009@iogearbox.net> <56E0583A.1080205@infradead.org> Cc: linux-kernel@vger.kernel.org, "netdev@vger.kernel.org" From: Randy Dunlap Message-ID: <56E05ACA.40602@infradead.org> Date: Wed, 9 Mar 2016 09:18:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56E0583A.1080205@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1205 Lines: 40 On 03/09/16 09:07, Randy Dunlap wrote: > On 03/09/16 08:48, Daniel Borkmann wrote: >> On 03/09/2016 05:44 PM, Randy Dunlap wrote: >>> On 03/08/16 21:38, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20160308: >>> >>> on x86_64: >>> >>> ../net/core/filter.c: In function 'bpf_skb_get_tunnel_opt': >>> ../net/core/filter.c:1824:2: error: implicit declaration of function 'ip_tunnel_info_opts_get' [-Werror=implicit-function-declaration] >>> ip_tunnel_info_opts_get(to, info); >>> ^ >>> ../net/core/filter.c: In function 'bpf_skb_set_tunnel_opt': >>> ../net/core/filter.c:1918:2: error: implicit declaration of function 'ip_tunnel_info_opts_set' [-Werror=implicit-function-declaration] >>> ip_tunnel_info_opts_set(info, from, size); >>> ^ >>> Full randconfig file is attached. >> >> Already fixed with net-next commit e28e87ed474c ("ip_tunnel, bpf: >> ip_tunnel_info_opts_{get, set} depends on CONFIG_INET"). >> >> Thanks, >> Daniel >> > > Hi Daniel, > > Is that patch on the netdev mailing list or patchwork? > I can't find it. > > Does it handle where net/Kconfig symbol NET selects BPF unconditionally? I got the patch from git and tested it. Works. Thanks. -- ~Randy