Date: Wed, 9 Mar 2016 20:01:50 +0100 (CET)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Michael Niewoehner <linux@mniewoehner.de>,
        Tao Huang <huangtao@rock-chips.com>,
        Julius Werner <jwerner@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        John Youn <johnyoun@synopsys.com>,
        Caesar Wang <caesar.upstream@gmail.com>,
        Heiko Stuebner <heiko@sntech.de>, Felipe Balbi <balbi@kernel.org>,
        Remi Pommarel <repk@triplefau.lt>
Message-ID: <941828343.8833.cdbd40c7-e6f4-4b3e-9665-30fc6680f6e0.open-xchange@email.1und1.de>
In-Reply-To: <CAD=FV=VygPvq+XxEwVCX8hofOGSsXGdPU6tKw6GPcQAkx8GZtA@mail.gmail.com>
References: <1457115786-11370-1-git-send-email-dianders@chromium.org>
 <1457115786-11370-2-git-send-email-dianders@chromium.org>
 <1400647253.149212.b3bb45b6-c852-4cf1-9d3e-9fb299176369.open-xchange@email.1und1.de>
 <CAD=FV=VygPvq+XxEwVCX8hofOGSsXGdPU6tKw6GPcQAkx8GZtA@mail.gmail.com>
Subject: Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on
 bcm2835"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Importance: Medium
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1526
Lines: 48


> Doug Anderson <dianders@chromium.org> hat am 7. März 2016 um 22:30
> geschrieben:
>
>
> Stefan,
>
> On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > Hi Doug,
> >
> >> Douglas Anderson <dianders@chromium.org> hat am 4. März 2016 um 19:23
> >> geschrieben:
> >>
> >>
> >> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on
> >> bcm2835") now that we've found the root cause. See the change
> >> titled ("usb: dwc2: Add a 10 ms delay to dwc2_core_reset()").
> >
> > adding a delay of 10 ms after a core reset might be a idea, but applying
> > both
> > patches breaks USB support on RPi :-(
> >
> > I'm getting the wrong register values ...
>
> Ugh. :(
>
> Just out of curiosity, if you loop and time long it takes for the
> registers to get to the right state after reset, what do you get?
> AKA, pick:
>
> https://chromium-review.googlesource.com/331260
>
> ...and let me know what it prints out. 

On my Raspberry Pi B i get the following:

[    2.084411] dwc2 20980000.usb: mapped PA 20980000 to VA cc880000
[    2.084461] dwc2 20980000.usb: cannot get otg clock
[    2.084549] dwc2 20980000.usb: registering common handler for irq33
[    2.084713] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host
[    2.153965] dwc2 20980000.usb: Waited 49996 us, 0x00201000 => 0x01001000,
0x00000000 => 0x02002000
[    2.174930] dwc2 20980000.usb: Forcing mode to host

So i changed the delay in patch #1 to msleep(50) and then both patches work like
a charm.

Stefan