Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866AbcCITCy (ORCPT ); Wed, 9 Mar 2016 14:02:54 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:51485 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753803AbcCITCi convert rfc822-to-8bit (ORCPT ); Wed, 9 Mar 2016 14:02:38 -0500 Date: Wed, 9 Mar 2016 20:01:50 +0100 (CET) From: Stefan Wahren To: Doug Anderson Cc: Michael Niewoehner , Tao Huang , Julius Werner , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , John Youn , Caesar Wang , Heiko Stuebner , Felipe Balbi , Remi Pommarel Message-ID: <941828343.8833.cdbd40c7-e6f4-4b3e-9665-30fc6680f6e0.open-xchange@email.1und1.de> In-Reply-To: References: <1457115786-11370-1-git-send-email-dianders@chromium.org> <1457115786-11370-2-git-send-email-dianders@chromium.org> <1400647253.149212.b3bb45b6-c852-4cf1-9d3e-9fb299176369.open-xchange@email.1und1.de> Subject: Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.0-Rev22 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:HHtG2pLmTeemRW5gpqIfYEupyCkW9KuWhza5X4JHj6fUihfsoIy tr1sCAAMkZz80ZYSBeGpLVjfbBZ1UwZdTc6ooVXjf5GDtRtBM50VTsPnh+1EV7H3uo3dwmC DQketnlZiqHBfeU2LqDAobfjX9d4tkWxtsKx/fJ4WNyiMMu7gbhom7GHFGiy2HxDJVima1w PxoH0vxGxFH4TMQgdQNtw== X-UI-Out-Filterresults: notjunk:1;V01:K0:mJ5QLmckbY4=:GVfqDZhNXmP1jN9rf45JQr i4oEAoaIkI1nvXE1cVNDKFwkEv8neIqtUAoX8BrnBl+tPdd6ECtQh0syTW5Jary8jd5BZ/Ugy t5CtrC5DI4VEkEfCcr+ItvinP0kzpJcpk0/8lfZ2WzHkm4758LyzKYLpP+K4fdxNrfUUYAgXw fNbqBDm3CxM77AqVI94/g+bpFxYFwqGmOFVCb0foR18nT1Ew/cGYAdaX9l4GqZQcD2ghKyVae T/+u6zzDxqnGG/cj/RXqsELCSkGoHFYyrparzCl7tkklP1/PdgX3PZagKAFU4IJGYV785r4H/ h3RsmBKljO0fuSkQjGlzsdD+3ppV8UV6WcNHWvwQ92idhhUKOZNBCaurspZyprcRFIIOu1+zN 6l+dFKdzfqjx1FC/o3TuRZmNVHfH8CtSWxXcUGgx7f5GG1yVejp/piW/aWsQozYbuBSH5bzuU 1e/4Gt5OREkd2noG+Vn+i1f3ESXGTJf7hM2KvXaY72UxhltBXlJejPEDwUDNPVxhoCvUWtDKR IRMFHyHPVzf0s1lmygNgFwvHOTnNGQrJVpDpOkE/JIFL7d7+QR3e/SrBclwL3RWho3l3sb0G6 zwF7LWWjLuoN7GNiOViqVYMdMzLIY+WyOpkCWFy5v+WKqjYS2FYApTQqQSIpDbeUT/fnN0QT/ AzrsfBPBy0gIU5xEleR4mZmUH20XhwrFV7Cz6ydv8S/cS2MOMBYqwMOdadImmRiPDuYPDsZuG qeKqFJZgDnwyTBXa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1526 Lines: 48 > Doug Anderson hat am 7. März 2016 um 22:30 > geschrieben: > > > Stefan, > > On Mon, Mar 7, 2016 at 10:40 AM, Stefan Wahren wrote: > > Hi Doug, > > > >> Douglas Anderson hat am 4. März 2016 um 19:23 > >> geschrieben: > >> > >> > >> This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on > >> bcm2835") now that we've found the root cause. See the change > >> titled ("usb: dwc2: Add a 10 ms delay to dwc2_core_reset()"). > > > > adding a delay of 10 ms after a core reset might be a idea, but applying > > both > > patches breaks USB support on RPi :-( > > > > I'm getting the wrong register values ... > > Ugh. :( > > Just out of curiosity, if you loop and time long it takes for the > registers to get to the right state after reset, what do you get? > AKA, pick: > > https://chromium-review.googlesource.com/331260 > > ...and let me know what it prints out. On my Raspberry Pi B i get the following: [ 2.084411] dwc2 20980000.usb: mapped PA 20980000 to VA cc880000 [ 2.084461] dwc2 20980000.usb: cannot get otg clock [ 2.084549] dwc2 20980000.usb: registering common handler for irq33 [ 2.084713] dwc2 20980000.usb: Configuration mismatch. dr_mode forced to host [ 2.153965] dwc2 20980000.usb: Waited 49996 us, 0x00201000 => 0x01001000, 0x00000000 => 0x02002000 [ 2.174930] dwc2 20980000.usb: Forcing mode to host So i changed the delay in patch #1 to msleep(50) and then both patches work like a charm. Stefan