Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934093AbcCIUSY (ORCPT ); Wed, 9 Mar 2016 15:18:24 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46960 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579AbcCIUSQ (ORCPT ); Wed, 9 Mar 2016 15:18:16 -0500 Date: Wed, 9 Mar 2016 12:18:08 -0800 From: Greg KH To: ygardi@codeaurora.org Cc: james.bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, Dolev Raviv , Gilad Broner , Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Neuling , "Matthew R. Ochs" , Wen Xiong , Subhash Jadavani , "open list:ABI/API" Subject: Re: [PATCH v7] scsi: ufs: add ioctl interface for query request Message-ID: <20160309201808.GA24568@kroah.com> References: <1457532699-11487-1-git-send-email-ygardi@codeaurora.org> <20160309162943.GC21181@kroah.com> <43117fbc4f3a305acd0f4975a633934a.squirrel@us.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43117fbc4f3a305acd0f4975a633934a.squirrel@us.codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 32 On Wed, Mar 09, 2016 at 07:09:49PM -0000, ygardi@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> ioctl interface. As of now UFS driver would provide the ioctl for query > >> interface to connected UFS device. > >> > >> Reviewed-by: Subhash Jadavani > >> Signed-off-by: Dolev Raviv > >> Signed-off-by: Gilad Broner > >> Signed-off-by: Yaniv Gardi > > > > What tool is going to use this ioctl? Why does userspcae want to do > > something "special" with UFS devices? Shouldn't they just be treated > > like any other normal block device? > > > > Any userspace application can be a tool. > We already implemented and used a user space application, that sent > queries to the UFS devices in order to get information and descriptors. But do you want to do with that information? Why does userspace care? > Not only ioctl interface is a useful way to interact with the device, > we used it, and found it very helpful in varies cases. In what case was it helpful? Why does userspace care about ufs specifics, it should just treat it like any other block device and not care at all. thanks, greg k-h